9 days agoincludes/characterlist.php: revert - move to patch includes/storyform.php
Clarissa Walker []
includes/characterlist.php: revert - move to patch includes/storyform.php

10 days agoincludes/characterlist.php: PHP 8.x warning fix - from upstream
Clarissa Walker []
includes/characterlist.php: PHP 8.x warning fix - from upstream

11 days agoblocks/menu/- admin.php, menu.php: further PHP fixes - undefined index notices (PHP 7.x)/undefined array key warnings (PHP 8.x), assumed unserialize() index/array warning and deprecation of false to array conversion in admin panel - this occurs in two scenarios: an entirely new install (menu entry's block_variables are empty on a new install), and with some skins that do not utilize a menu block array in their variables.php file (or don't even have a variables.php file at all)
Clarissa Walker []
blocks/menu/- admin.php, menu.php: further PHP fixes - undefined index notices (PHP 7.x)/undefined array key warnings (PHP 8.x), assumed unserialize() index/array warning and deprecation of false to array conversion in admin panel - this occurs in two scenarios: an entirely new install (menu entry's block_variables are empty on a new install), and with some skins that do not utilize a menu block array in their variables.php file (or don't even have a variables.php file at all)

11 days agoincludes/characterlist.php: Somehow having two copies of the same exact function stops the character list from bugging out when using the category list while using tinyMCE 4.x or newer - also somehow no PHP errors, either...
Clarissa Walker []
includes/characterlist.php: Somehow having two copies of the same exact function stops the character list from bugging out when using the category list while using tinyMCE 4.x or newer - also somehow no PHP errors, either...

12 days agoblocks/menu/menu.php: PHP 8.5.x deprecations fix
Clarissa Walker []
blocks/menu/menu.php: PHP 8.5.x deprecations fix

12 days agoadmin/blocks.php: security - potential path traversal
Clarissa Walker []
admin/blocks.php: security - potential path traversal

2 weeks agoincludes/mysqli_functions.php: change empty string to quoted NULL strings - as some entries in the database are already empty strings as well and can be easily confused otherwise
Clarissa Walker []
includes/mysqli_functions.php: change empty string to quoted NULL strings - as some entries in the database are already empty strings as well and can be easily confused otherwise

2 weeks agoadmin/members.php, includes/- button.php, plain.button.php, user/lostpassword.php: casting from double to float due to deprecation notice - fix
Clarissa Walker []
admin/members.php, includes/- button.php, plain.button.php, user/lostpassword.php: casting from double to float due to deprecation notice - fix

2 weeks agoincludes/emailer.php: restore cut-off comment
Clarissa Walker []
includes/emailer.php: restore cut-off comment

2 weeks agoincludes/deletefunctions.php: more forgotten coauthors reverts
Clarissa Walker []
includes/deletefunctions.php: more forgotten coauthors reverts

2 weeks agoincludes/mysqli_functions.php: mysqli_real_escape_string() does not like null entries [deprecated since PHP 8.1], so an empty string should take their place - fix
Clarissa Walker []
includes/mysqli_functions.php: mysqli_real_escape_string() does not like null entries [deprecated since PHP 8.1], so an empty string should take their place - fix

2 weeks agoadmin/backup.php, admin/backup_utf8.php, includes/get_session_vars.php: changes to database backup behavior - deprecations fix, revert encode in utf8 variant... also apparently get_session_vars fatals with the backup tools when using isNumber, so is_int is used instead
Clarissa Walker []
admin/backup.php, admin/backup_utf8.php, includes/get_session_vars.php: changes to database backup behavior - deprecations fix, revert encode in utf8 variant... also apparently get_session_vars fatals with the backup tools when using isNumber, so is_int is used instead

2 weeks agosearch.php: Definitive fix for very old sorting order oversight - Noticed after looking at the original patch and the original line; can't believe it was that simple...
Clarissa Walker []
search.php: Definitive fix for very old sorting order oversight - Noticed after looking at the original patch and the original line; can't believe it was that simple...

2 weeks agoinstall/install.php: duplicate line oversight removal
Clarissa Walker []
install/install.php: duplicate line oversight removal

2 weeks agouser/editprefs.php: remove space between checkbox and help popover toolbox
Clarissa Walker []
user/editprefs.php: remove space between checkbox and help popover toolbox

2 weeks agosearch.php: margin spacing between the search term textbox and the submit button cosmetic fix
Clarissa Walker []
search.php: margin spacing between the search term textbox and the submit button cosmetic fix

2 weeks agonews.php: change back to fork-specific time() instead of original now() - does not use datetimes, but Unix timestamps in database
Clarissa Walker []
news.php: change back to fork-specific time() instead of original now() - does not use datetimes, but Unix timestamps in database

2 weeks agonews.php: remove NID 0 check as it breaks pagination (shows not found) - and it seems it is not needed after all
Clarissa Walker []
news.php: remove NID 0 check as it breaks pagination (shows not found) - and it seems it is not needed after all

2 weeks agoinstall/install.php: fix self-induced deletion of config.php creation - I blame my main laptop's touchpad for this
Clarissa Walker []
install/install.php: fix self-induced deletion of config.php creation - I blame my main laptop's touchpad for this

2 weeks agofrom FanficTalk-Archive: fixing bug with viewing reviews by chapters - Not obvious with this fork with Unix timestamps as dates, wonder if it affects versions with datetimes as dates
Clarissa Walker []
from FanficTalk-Archive: fixing bug with viewing reviews by chapters - Not obvious with this fork with Unix timestamps as dates, wonder if it affects versions with datetimes as dates

2 weeks agoreviews.php: from FanficTalk-Archive: block locked accounts from posting reviews - Apparently, this was possible before...
Clarissa Walker []
reviews.php: from FanficTalk-Archive: block locked accounts from posting reviews - Apparently, this was possible before...

2 weeks agosearch.php: fix very old oversight with Sorting Order (Alphabetical/Most Recent) not working in Advanced Search
Clarissa Walker []
search.php: fix very old oversight with Sorting Order (Alphabetical/Most Recent) not working in Advanced Search

2 weeks agouser/favau.php: fix bug with adding an already-favorited author as favorites handling bringing up PHP warnings and bugging out the entire thing
Clarissa Walker []
user/favau.php: fix bug with adding an already-favorited author as favorites handling bringing up PHP warnings and bugging out the entire thing

2 weeks agomodules/challenges/otherresults.php: change filter to match other patched modules
Clarissa Walker []
modules/challenges/otherresults.php: change filter to match other patched modules

2 weeks agomodules/challenges/challenges.php: fix Undefined constant PHP 8.x error message due to the fact that it was missing the language file includes
Clarissa Walker []
modules/challenges/challenges.php: fix Undefined constant PHP 8.x error message due to the fact that it was missing the language file includes

2 weeks agomodules/challenges/challenges.php: convert PHP 7+ only coalescing operator to ternary to support PHP 5+ - was unwittingly introduced in a security patch at some point
Clarissa Walker []
modules/challenges/challenges.php: convert PHP 7+ only coalescing operator to ternary to support PHP 5+ - was unwittingly introduced in a security patch at some point

2 weeks agosearch.php: countquery DISTINCT order fix - it is needed, but was in the wrong place
Clarissa Walker []
search.php: countquery DISTINCT order fix - it is needed, but was in the wrong place

2 weeks agosearch.php: fix chapter (and further fix penname) search entries showing up more than once in results in certain conditions
Clarissa Walker []
search.php: fix chapter (and further fix penname) search entries showing up more than once in results in certain conditions

2 weeks agosearch.php: only try to display validated chapters in search results (mysql storage only)
Clarissa Walker []
search.php: only try to display validated chapters in search results (mysql storage only)

2 weeks agosearch.php: fix penname search entries showing up more than once in results in certain conditions
Clarissa Walker []
search.php: fix penname search entries showing up more than once in results in certain conditions

2 weeks agosearch.php: fix series results displaying all entries for a given series instead of using the search terms for a given series
Clarissa Walker []
search.php: fix series results displaying all entries for a given series instead of using the search terms for a given series

2 weeks agobrowse.php, search.php: revert changes, as it breaks ePubVerstion support at this time
Clarissa Walker []
browse.php, search.php: revert changes, as it breaks ePubVerstion support at this time

2 weeks agobrowse.php, search.php, includes/categorylist.php: patches from upstream, with some exceptions - search.php needs Ami-fixed old behavior in the penname results due to new upstream version bugging out in MySQL strict error reporting mode; browse.php has searchtype errorExit() behavior commented out as it crashes series results, other results are fine
Clarissa Walker []
browse.php, search.php, includes/categorylist.php: patches from upstream, with some exceptions - search.php needs Ami-fixed old behavior in the penname results due to new upstream version bugging out in MySQL strict error reporting mode; browse.php has searchtype errorExit() behavior commented out as it crashes series results, other results are fine

2 weeks agolanguages/en.php: fix annoying lack of space in error message, e.g. Error!We -> Error! We
Clarissa Walker []
languages/en.php: fix annoying lack of space in error message, e.g. Error!We -> Error! We

2 weeks agouser/revres.php: fix Uncaught TypeError for PHP 8.x when trying to access an author review response to a nonexistent review - sub-issue is an Undefined variable warning when doing so as well
Clarissa Walker []
user/revres.php: fix Uncaught TypeError for PHP 8.x when trying to access an author review response to a nonexistent review - sub-issue is an Undefined variable warning when doing so as well

2 weeks agosearch.php: fix ancient rewrite oversight from eFiction 3.2 or 3.2.1
Clarissa Walker []
search.php: fix ancient rewrite oversight from eFiction 3.2 or 3.2.1

2 weeks agoupdate.php: SQL query fix
Clarissa Walker []
update.php: SQL query fix

2 weeks agoAdd option to enable or disable ratings abuse guard
Clarissa Walker []
Add option to enable or disable ratings abuse guard

3 weeks agoreviews.php: fix Uncaught TypeError in PHP 8.x with leaving a review with co-authors - seems related to the newer upstream patches
Clarissa Walker []
reviews.php: fix Uncaught TypeError in PHP 8.x with leaving a review with co-authors - seems related to the newer upstream patches

3 weeks agoincludes/corefunctions.php: patches from upstream
Clarissa Walker []
includes/corefunctions.php: patches from upstream

3 weeks agoreviews.php: stupid typo in check, temp fix for coauthors variable behavior
Clarissa Walker []
reviews.php: stupid typo in check, temp fix for coauthors variable behavior

3 weeks agoviewstory.php: Remove accidentally committed print mod... again
Clarissa Walker []
viewstory.php: Remove accidentally committed print mod... again

3 weeks agosearch.php: Truly fix the MySQL error message overwriting the Search Results header for a failed penname search - brings it to PHP 5+ support
Clarissa Walker []
search.php: Truly fix the MySQL error message overwriting the Search Results header for a failed penname search - brings it to PHP 5+ support

3 weeks agoincludes/userlist.php: remove PHP 5+ patch, as apparently the original Error 500 issue was related to the old languages/en.php variable issue
Clarissa Walker []
includes/userlist.php: remove PHP 5+ patch, as apparently the original Error 500 issue was related to the old languages/en.php variable issue

3 weeks agoincludes/userlist.php: PHP 5+ support
Clarissa Walker []
includes/userlist.php: PHP 5+ support

3 weeks agosearch.php: Patch 'searchterm' unescaping bug that shows all stories instead of none if searching a penname that does not exist
Clarissa Walker []
search.php: Patch 'searchterm' unescaping bug that shows all stories instead of none if searching a penname that does not exist

3 weeks agoBugfix patches from upstream - and general cleanup of old hacks
Clarissa Walker []
Bugfix patches from upstream - and general cleanup of old hacks

3 weeks agoSecurity patches from upstream - and general cleanup of old hacks
Clarissa Walker []
Security patches from upstream - and general cleanup of old hacks

3 weeks agoThis eFiction 3 fork now supports PHPMailer 6 (and possibly newer) versions - also general cleanup related to this
Clarissa Walker []
This eFiction 3 fork now supports PHPMailer 6 (and possibly newer) versions - also general cleanup related to this

3 weeks agoincludes/mysqli_functions.php: fix typo in error debug entry
Clarissa Walker []
includes/mysqli_functions.php: fix typo in error debug entry

3 weeks agoviewstory.php: Remove accidentally committed print mod
Clarissa Walker []
viewstory.php: Remove accidentally committed print mod

3 weeks agoinstall/install.php: re-implement config.php setup from eFiction 3.5.72
Clarissa Walker []
install/install.php: re-implement config.php setup from eFiction 3.5.72

3 weeks agouser/editprefs.php: do not use old register_globals patch and use original variable instead - same end result
Clarissa Walker []
user/editprefs.php: do not use old register_globals patch and use original variable instead - same end result

3 weeks agoincludes/corefunctions.php: add CSS class for skin support of Number of Likes 'Likes:' text via .likes-rating - otherwise a full CSS path would be required to change it
Clarissa Walker []
includes/corefunctions.php: add CSS class for skin support of Number of Likes 'Likes:' text via .likes-rating - otherwise a full CSS path would be required to change it

3 weeks agobrowse/class.php, browse/ratings.php: more PHP 8 warnings fixes, PHP 5.6 (!) support...
Clarissa Walker []
browse/class.php, browse/ratings.php: more PHP 8 warnings fixes, PHP 5.6 (!) support...

3 weeks agouser/profile.php: PHP 7+ coalescing to PHP 5+ ternary and further defined variables
Clarissa Walker []
user/profile.php: PHP 7+ coalescing to PHP 5+ ternary and further defined variables

3 weeks agonews.php: Somehow forgot this particular comments patch...
Clarissa Walker []
news.php: Somehow forgot this particular comments patch...

3 weeks agonews.php, reviews.php: Some dirty fixes for PHP warnings are no longer needed since the checks, but three more are used in reviews.php for item 0
Clarissa Walker []
news.php, reviews.php: Some dirty fixes for PHP warnings are no longer needed since the checks, but three more are used in reviews.php for item 0

3 weeks agoviewstory.php: Undefined variable PHP warnings when trying to access a nonexistent or formerly existing chapter in a story dirty fix
Clarissa Walker []
viewstory.php: Undefined variable PHP warnings when trying to access a nonexistent or formerly existing chapter in a story dirty fix

3 weeks agonews.php: consistency change
Clarissa Walker []
news.php: consistency change

3 weeks agonews.php: add previously nonexistent check for nonexistent or formerly existing news entries... and UID 0
Clarissa Walker []
news.php: add previously nonexistent check for nonexistent or formerly existing news entries... and UID 0

3 weeks agonews.php: Trying to access array offset on null warning for PHP 8 users dirty fix
Clarissa Walker []
news.php: Trying to access array offset on null warning for PHP 8 users dirty fix

3 weeks agoheader.php, reviews.php, viewstory.php, viewuser.php, admin/panels.php, browse/class.php, browse/ratings.php: PHP 7+ coalescing to PHP 5+ ternary and further defined variables - admin/panels.php: fix self-caused isset flaw displaying panel types in drop-down menu as 1
Clarissa Walker []
header.php, reviews.php, viewstory.php, viewuser.php, admin/panels.php, browse/class.php, browse/ratings.php: PHP 7+ coalescing to PHP 5+ ternary and further defined variables - admin/panels.php: fix self-caused isset flaw displaying panel types in drop-down menu as 1

3 weeks agoviewseries.php: fix up the series existing check - this incidentally removes the PHP 7+ requirement...
Clarissa Walker []
viewseries.php: fix up the series existing check - this incidentally removes the PHP 7+ requirement...

3 weeks agobrowse.php, search.php, includes/corefunctions.php: further security patches...
Clarissa Walker []
browse.php, search.php, includes/corefunctions.php: further security patches...

3 weeks agoadmin.php, admin/custpages.php, admin/messages.php: Revert initial CSRF protection changes - The rest of the CSRF stuff are in more than one commit, so it has to be done in one batch
Clarissa Walker []
admin.php, admin/custpages.php, admin/messages.php: Revert initial CSRF protection changes - The rest of the CSRF stuff are in more than one commit, so it has to be done in one batch

3 weeks agoincludes/seriesreviews.php: Ratingsvs reviews total count discrepancy patch from @ariadoss
Clarissa Walker []
includes/seriesreviews.php: Ratingsvs reviews total count discrepancy patch from @ariadoss

3 weeks agouser/editprefs.php: Finally fix ~20-year-old skin selecting bug! Here was the bug in question: If your future selected skin was going to be the same as the default site's selected skin, it would not change at all unless you selected it at the site's drop-down menu, then it now became your account's selected skin. Also forgotten formmating change
Clarissa Walker []
user/editprefs.php: Finally fix ~20-year-old skin selecting bug! Here was the bug in question: If your future selected skin was going to be the same as the default site's selected skin, it would not change at all unless you selected it at the site's drop-down menu, then it now became your account's selected skin. Also forgotten formmating change

3 weeks agoadmin/panels.php: Undefined array key PHP 8 warning on viewing a panel with null entries and Trying to access array offset on null PHP 8 warning dirty fixes
Clarissa Walker []
admin/panels.php: Undefined array key PHP 8 warning on viewing a panel with null entries and Trying to access array offset on null PHP 8 warning dirty fixes

3 weeks agodefault_tpls/listings.tpl: fix layout lacking a space between the author's name and the selected review rating for the listing of series in the browse page
Clarissa Walker []
default_tpls/listings.tpl: fix layout lacking a space between the author's name and the selected review rating for the listing of series in the browse page

3 weeks agodefault_tpls/storyindex.tpl: fix layout lacking a space between the selected review rating and the print icon in a story's Table of Contents page
Clarissa Walker []
default_tpls/storyindex.tpl: fix layout lacking a space between the selected review rating and the print icon in a story's Table of Contents page

3 weeks agoincludes/corefunctions.php: update javascript stripping regex - from @ariadoss
Clarissa Walker []
includes/corefunctions.php: update javascript stripping regex - from @ariadoss

3 weeks agoheader.php, search.php, includes/- corefunctions.php, upload_class.php: Security - local file inclusion/directory traversal and encode echoed terms patches - from @ariadoss
Clarissa Walker []
header.php, search.php, includes/- corefunctions.php, upload_class.php: Security - local file inclusion/directory traversal and encode echoed terms patches - from @ariadoss

3 weeks agoupdate eFic2eFic bridge and default files
Clarissa Walker []
update eFic2eFic bridge and default files

3 weeks agoadmin/custpages.php: restore trailing space - editor change...
Clarissa Walker []
admin/custpages.php: restore trailing space - editor change...

3 weeks agoincludes/mysqli_functions.php: further disable ONLY_FULL_GROUP_BY setting, partially bring back MYSQL40 compat, remove STRICT_TRANS_TABLES due to MyISAM use - a variant of this shows up in newer eFiction 3.5.72
Clarissa Walker []
includes/mysqli_functions.php: further disable ONLY_FULL_GROUP_BY setting, partially bring back MYSQL40 compat, remove STRICT_TRANS_TABLES due to MyISAM use - a variant of this shows up in newer eFiction 3.5.72

3 weeks agoheader.php, user.php, user/login.php: Security - Session and Remember Me cookies are now marked httponly and Lax, previously nonexistent - from @ariadoss
Clarissa Walker []
header.php, user.php, user/login.php: Security - Session and Remember Me cookies are now marked httponly and Lax, previously nonexistent - from @ariadoss

3 weeks agoadmin/messages.php: Security - CSRF protection for admin message forms; viewpage.php, admin/custpages.php: Security - do not execute PHP in stored pages and CSRF protection, but delete is a confirmation prompt instead - from @ariadoss
Clarissa Walker []
admin/messages.php: Security - CSRF protection for admin message forms; viewpage.php, admin/custpages.php: Security - do not execute PHP in stored pages and CSRF protection, but delete is a confirmation prompt instead - from @ariadoss

3 weeks agoviewstory.php: Undefined variable warnings while trying to access a nonexistent chapter for an existing story final dirty fix for PHP 8 users
Clarissa Walker []
viewstory.php: Undefined variable warnings while trying to access a nonexistent chapter for an existing story final dirty fix for PHP 8 users

3 weeks agoviewstory.php: Undefined variable warnings while trying to access a nonexistent chapter for an existing story better dirty fix for PHP 8 users
Clarissa Walker []
viewstory.php: Undefined variable warnings while trying to access a nonexistent chapter for an existing story better dirty fix for PHP 8 users

3 weeks agoviewstory.php: Undefined variables while trying to access a nonexistent chapter for an existing story dirty fix for PHP 8 users
Clarissa Walker []
viewstory.php: Undefined variables while trying to access a nonexistent chapter for an existing story dirty fix for PHP 8 users

3 weeks agoreviews.php, series.php, viewstory.php, user/- editbio.php, login.php, profile.php, revres.php: Security - Various takeover patches - from @ariadoss
Clarissa Walker []
reviews.php, series.php, viewstory.php, user/- editbio.php, login.php, profile.php, revres.php: Security - Various takeover patches - from @ariadoss

3 weeks agoadmin.php, browse.php, user.php, includes/get_session_vars.php: Security - SQL injection patches - from @ariadoss
Clarissa Walker []
admin.php, browse.php, user.php, includes/get_session_vars.php: Security - SQL injection patches - from @ariadoss

3 weeks agoincludes/mysqli_functions.php: disable ONLY_FULL_GROUP_BY setting - a variant of this shows up in newer eFiction 3.5.72
Clarissa Walker []
includes/mysqli_functions.php: disable ONLY_FULL_GROUP_BY setting - a variant of this shows up in newer eFiction 3.5.72

3 weeks agoadmin/stories.php: some lines changed from dbassoc to dbfetcharray as the original code called for this
Clarissa Walker []
admin/stories.php: some lines changed from dbassoc to dbfetcharray as the original code called for this

3 weeks agodocs/config.php, install/install.php: do not interpolate strings in any config.php file - security
Clarissa Walker []
docs/config.php, install/install.php: do not interpolate strings in any config.php file - security

3 weeks agoinstall/install.php: fix case '2' semicolon oversight
Clarissa Walker []
install/install.php: fix case '2' semicolon oversight

3 weeks agoreviews.php: Ratings abuse patch from @ariadoss
Clarissa Walker []
reviews.php: Ratings abuse patch from @ariadoss

3 weeks agoinstall/install.php: Be a bit more paranoid regarding security with variables
Clarissa Walker []
install/install.php: Be a bit more paranoid regarding security with variables

3 weeks agochmod fix
Clarissa Walker []
chmod fix

4 weeks agoblocks/categories/categories.php, includes/storyblock.php: eFiction database function change
Clarissa Walker []
blocks/categories/categories.php, includes/storyblock.php: eFiction database function change

4 weeks agoadmin/genres.php, admin/warnings.php: eFiction database function change - technically not used here, but still...
Clarissa Walker []
admin/genres.php, admin/warnings.php: eFiction database function change - technically not used here, but still...

4 weeks agoincludes/corefunctions.php: Add utf8 shims from eFiction 3.5.72 - solves future PHP 9 deprecation and removal
Clarissa Walker []
includes/corefunctions.php: Add utf8 shims from eFiction 3.5.72 - solves future PHP 9 deprecation and removal

4 weeks agoadmin/stories.php, includes/mysqli_functions.php: Database function changes from eFiction 3.5.72 - keep the MySQL strict mode behavior
Clarissa Walker []
admin/stories.php, includes/mysqli_functions.php: Database function changes from eFiction 3.5.72 - keep the MySQL strict mode behavior

4 weeks agoincludes/storyblock.php: Code formatting
Clarissa Walker []
includes/storyblock.php: Code formatting

4 weeks agoadmin/backup_utf8.php: Properly fix UTF-8 database dump function - from newly released eFiction 3.5.72 codebase
Clarissa Walker []
admin/backup_utf8.php: Properly fix UTF-8 database dump function - from newly released eFiction 3.5.72 codebase

5 weeks agoadmin/categories.php: Formatting changes
Clarissa Walker []
admin/categories.php: Formatting changes

5 weeks agoviewuser.php: Formatting goof fix
Clarissa Walker []
viewuser.php: Formatting goof fix

5 weeks agoviewuser.php: Add previously nonexistent check for nonexistent or formerly existing users... oh, and UID 0 - should probably use a better message than the generic database one, though
Clarissa Walker []
viewuser.php: Add previously nonexistent check for nonexistent or formerly existing users... oh, and UID 0 - should probably use a better message than the generic database one, though

5 weeks agoincludes/seriesreviews.php: Make PHP 8 fix more human-readable - part 2
Clarissa Walker []
includes/seriesreviews.php: Make PHP 8 fix more human-readable - part 2