includes/mysqli_functions.php: change empty string to quoted NULL strings - as some entries in the database are already empty strings as well and can be easily confused otherwise
includes/mysqli_functions.php: mysqli_real_escape_string() does not like null entries [deprecated since PHP 8.1], so an empty string should take their place - fix
admin/backup.php, admin/backup_utf8.php, includes/get_session_vars.php: changes to database backup behavior - deprecations fix, revert encode in utf8 variant... also apparently get_session_vars fatals with the backup tools when using isNumber, so is_int is used instead
search.php: Definitive fix for very old sorting order oversight - Noticed after looking at the original patch and the original line; can't believe it was that simple...
from FanficTalk-Archive: fixing bug with viewing reviews by chapters - Not obvious with this fork with Unix timestamps as dates, wonder if it affects versions with datetimes as dates
modules/challenges/install.php: convert database table install from MyISAM -> InnoDB and change default collation for some columns - there exists a standalone version archive for the original behavior
modules/challenges/challenges.php: convert PHP 7+ only coalescing operator to ternary to support PHP 5+ - was unwittingly introduced in a security patch at some point
browse.php, search.php, includes/categorylist.php: patches from upstream, with some exceptions - search.php needs Ami-fixed old behavior in the penname results due to new upstream version bugging out in MySQL strict error reporting mode; browse.php has searchtype errorExit() behavior commented out as it crashes series results, other results are fine
user/revres.php: fix Uncaught TypeError for PHP 8.x when trying to access an author review response to a nonexistent review - sub-issue is an Undefined variable warning when doing so as well
includes/corefunctions.php: add CSS class for skin support of Number of Likes 'Likes:' text via .likes-rating - otherwise a full CSS path would be required to change it
header.php, reviews.php, viewstory.php, viewuser.php, admin/panels.php, browse/class.php, browse/ratings.php: PHP 7+ coalescing to PHP 5+ ternary and further defined variables - admin/panels.php: fix self-caused isset flaw displaying panel types in drop-down menu as 1
admin.php, admin/custpages.php, admin/messages.php: Revert initial CSRF protection changes - The rest of the CSRF stuff are in more than one commit, so it has to be done in one batch
user/editprefs.php: Finally fix ~20-year-old skin selecting bug! Here was the bug in question: If your future selected skin was going to be the same as the default site's selected skin, it would not change at all unless you selected it at the site's drop-down menu, then it now became your account's selected skin.
seriesreviews.php: rate-only submissions count toward the series rating (issue #11)
The rating UPDATE was gated on the text-review count, which is 0 when
Allow Ratings Only is on, so the recomputed rating never landed. Both
gates (the series and the parent walk) now key on the rating aggregate;
AVG's NULL still keeps the update silent when nothing was rated, and
the ?? 0 in the guarded lines is gone (PHP 5 friendly, see issue #10).
admin/panels.php: Undefined array key PHP 8 warning on viewing a panel with null entries and Trying to access array offset on null PHP 8 warning dirty fixes
default_tpls/listings.tpl: fix layout lacking a space between the author's name and the selected review rating for the listing of series in the browse page
includes/mysqli_functions.php: further disable ONLY_FULL_GROUP_BY setting, partially bring back MYSQL40 compat - a variant of this shows up in newer eFiction 3.5.72
header.php, user.php, user/login.php: Security - Session and Remember Me cookies are now marked httponly and Lax, previously nonexistent - from @ariadoss
admin/messages.php: Security - CSRF protection for admin message forms; viewpage.php, admin/custpages.php: Security - do not execute PHP in stored pages and CSRF protection, but delete is a confirmation prompt instead - from @ariadoss
reviews.php: one rating per member per story/series (issue #8)
A repeat submission by a logged-in member now revises their existing
review row instead of inserting a fresh one and walking the story or
series average. Anonymous submissions keep the old behavior; the edit
path is untouched, so the warnings the earlier POST-side rate check hit
cannot recur. The same guard is going into Hyperion360/efiction.