default_tpls/viewstory.tpl: add prev/next pagination buttons above the chapter, useful for long-form chapters - they are placed just above the story notes, if they ever exist - some existing skins will have to be modified to support this
admin/versioncheck.php: bring back original versioncheck.php script, but update it for the following: URL change, remove any padding in version number output, update ancient user agent for cURL version, severely limit version number character count (should not exceed 7 at the moment), preliminary check for invalid version numbers (will not output a Github link if that ever happens)
series.php, includes/storyform.php: move multiple selections message to just before the characters list order, so it will not disappear for users with only one category option
includes/categories.php: change constant to show the multiple categories message instead of the multiple selections message - when categories option is 'Only one', the multiple selections message is gone along with the category selection
includes/storyform.php: remove 'None' option from adding/editing stories for characters, as selecting none in the list achieves the same effect - this particular option is not even present when adding/editing series
Merge pull request #14 from ariadoss/fix/characterlist-element-and-duplicate
characterlist.php: remove the duplicate isNumber() - Merge this anyway (original reason was the redundant 'None' option for stories), then patch includes/storyform.php
includes/characterlist.php: remove the duplicate isNumber() - two identical top-level declarations are a parse-time fatal (Cannot redeclare) in every PHP version, so the file cannot run with both copies present
blocks/menu/- admin.php, menu.php: further PHP fixes - undefined index notices (PHP 7.x)/undefined array key warnings (PHP 8.x), assumed unserialize() index/array warning and deprecation of false to array conversion in admin panel - this occurs in two scenarios: an entirely new install (menu entry's block_variables are empty on a new install), and with some skins that do not utilize a menu block array in their variables.php file (or don't even have a variables.php file at all)
includes/characterlist.php: Somehow having two copies of the same exact function stops the character list from bugging out when using the category list while using tinyMCE 4.x or newer - also somehow no PHP errors, either...
includes/mysqli_functions.php: change empty string to quoted NULL strings - as some entries in the database are already empty strings as well and can be easily confused otherwise
includes/mysqli_functions.php: mysqli_real_escape_string() does not like null entries [deprecated since PHP 8.1], so an empty string should take their place - fix
admin/backup.php, admin/backup_utf8.php, includes/get_session_vars.php: changes to database backup behavior - deprecations fix, revert encode in utf8 variant... also apparently get_session_vars fatals with the backup tools when using isNumber, so is_int is used instead
search.php: Definitive fix for very old sorting order oversight - Noticed after looking at the original patch and the original line; can't believe it was that simple...
from FanficTalk-Archive: fixing bug with viewing reviews by chapters - Not obvious with this fork with Unix timestamps as dates, wonder if it affects versions with datetimes as dates
modules/challenges/install.php: convert database table install from MyISAM -> InnoDB and change default collation for some columns - there exists a standalone version archive for the original behavior
modules/challenges/challenges.php: convert PHP 7+ only coalescing operator to ternary to support PHP 5+ - was unwittingly introduced in a security patch at some point
browse.php, search.php, includes/categorylist.php: patches from upstream, with some exceptions - search.php needs Ami-fixed old behavior in the penname results due to new upstream version bugging out in MySQL strict error reporting mode; browse.php has searchtype errorExit() behavior commented out as it crashes series results, other results are fine
user/revres.php: fix Uncaught TypeError for PHP 8.x when trying to access an author review response to a nonexistent review - sub-issue is an Undefined variable warning when doing so as well
includes/corefunctions.php: add CSS class for skin support of Number of Likes 'Likes:' text via .likes-rating - otherwise a full CSS path would be required to change it
header.php, reviews.php, viewstory.php, viewuser.php, admin/panels.php, browse/class.php, browse/ratings.php: PHP 7+ coalescing to PHP 5+ ternary and further defined variables - admin/panels.php: fix self-caused isset flaw displaying panel types in drop-down menu as 1
admin.php, admin/custpages.php, admin/messages.php: Revert initial CSRF protection changes - The rest of the CSRF stuff are in more than one commit, so it has to be done in one batch
user/editprefs.php: Finally fix ~20-year-old skin selecting bug! Here was the bug in question: If your future selected skin was going to be the same as the default site's selected skin, it would not change at all unless you selected it at the site's drop-down menu, then it now became your account's selected skin.