3 weeks agoBugfix patches from upstream - and general cleanup of old hacks
Clarissa Walker []
Bugfix patches from upstream - and general cleanup of old hacks

3 weeks agoSecurity patches from upstream - and general cleanup of old hacks
Clarissa Walker []
Security patches from upstream - and general cleanup of old hacks

3 weeks agoThis eFiction 3 fork now supports PHPMailer 6 (and possibly newer) versions - also general cleanup related to this
Clarissa Walker []
This eFiction 3 fork now supports PHPMailer 6 (and possibly newer) versions - also general cleanup related to this

3 weeks agoUpdate README.md
Clarissa Walker []
Update README.md

3 weeks agoincludes/mysqli_functions.php: fix typo in error debug entry
Clarissa Walker []
includes/mysqli_functions.php: fix typo in error debug entry

3 weeks agoviewstory.php: Remove accidentally committed print mod
Clarissa Walker []
viewstory.php: Remove accidentally committed print mod

3 weeks agoinstall/install.php: re-implement config.php setup from eFiction 3.5.72
Clarissa Walker []
install/install.php: re-implement config.php setup from eFiction 3.5.72

3 weeks agouser/editprefs.php: do not use old register_globals patch and use original variable instead - same end result
Clarissa Walker []
user/editprefs.php: do not use old register_globals patch and use original variable instead - same end result

3 weeks agoincludes/corefunctions.php: add CSS class for skin support of Number of Likes 'Likes:' text via .likes-rating - otherwise a full CSS path would be required to change it
Clarissa Walker []
includes/corefunctions.php: add CSS class for skin support of Number of Likes 'Likes:' text via .likes-rating - otherwise a full CSS path would be required to change it

3 weeks agobrowse/class.php, browse/ratings.php: more PHP 8 warnings fixes, PHP 5.6 (!) support...
Clarissa Walker []
browse/class.php, browse/ratings.php: more PHP 8 warnings fixes, PHP 5.6 (!) support...

3 weeks agouser/profile.php: PHP 7+ coalescing to PHP 5+ ternary and further defined variables
Clarissa Walker []
user/profile.php: PHP 7+ coalescing to PHP 5+ ternary and further defined variables

3 weeks agonews.php: Somehow forgot this particular comments patch...
Clarissa Walker []
news.php: Somehow forgot this particular comments patch...

3 weeks agonews.php, reviews.php: Some dirty fixes for PHP warnings are no longer needed since the checks, but three more are used in reviews.php for item 0
Clarissa Walker []
news.php, reviews.php: Some dirty fixes for PHP warnings are no longer needed since the checks, but three more are used in reviews.php for item 0

3 weeks agoviewstory.php: Undefined variable PHP warnings when trying to access a nonexistent or formerly existing chapter in a story dirty fix
Clarissa Walker []
viewstory.php: Undefined variable PHP warnings when trying to access a nonexistent or formerly existing chapter in a story dirty fix

3 weeks agonews.php: consistency change
Clarissa Walker []
news.php: consistency change

3 weeks agonews.php: add previously nonexistent check for nonexistent or formerly existing news entries... and UID 0
Clarissa Walker []
news.php: add previously nonexistent check for nonexistent or formerly existing news entries... and UID 0

3 weeks agonews.php: Trying to access array offset on null warning for PHP 8 users dirty fix
Clarissa Walker []
news.php: Trying to access array offset on null warning for PHP 8 users dirty fix

3 weeks agoheader.php, reviews.php, viewstory.php, viewuser.php, admin/panels.php, browse/class.php, browse/ratings.php: PHP 7+ coalescing to PHP 5+ ternary and further defined variables - admin/panels.php: fix self-caused isset flaw displaying panel types in drop-down menu as 1
Clarissa Walker []
header.php, reviews.php, viewstory.php, viewuser.php, admin/panels.php, browse/class.php, browse/ratings.php: PHP 7+ coalescing to PHP 5+ ternary and further defined variables - admin/panels.php: fix self-caused isset flaw displaying panel types in drop-down menu as 1

3 weeks agoviewseries.php: fix up the series existing check - this incidentally removes the PHP 7+ requirement...
Clarissa Walker []
viewseries.php: fix up the series existing check - this incidentally removes the PHP 7+ requirement...

3 weeks agobrowse.php, search.php, includes/corefunctions.php: further security patches...
Clarissa Walker []
browse.php, search.php, includes/corefunctions.php: further security patches...

3 weeks agoadmin.php, admin/custpages.php, admin/messages.php: Revert initial CSRF protection changes - The rest of the CSRF stuff are in more than one commit, so it has to be done in one batch
Clarissa Walker []
admin.php, admin/custpages.php, admin/messages.php: Revert initial CSRF protection changes - The rest of the CSRF stuff are in more than one commit, so it has to be done in one batch

3 weeks agoMerge pull request #12 from ariadoss/fix/series-rateonly-rating-issue11
Clarissa Walker []
Merge pull request #12 from ariadoss/fix/series-rateonly-rating-issue11

seriesreviews.php: rate-only submissions count toward the series rating (fixes #11)

3 weeks agouser/editprefs.php: Finally fix ~20-year-old skin selecting bug! Here was the bug in question: If your future selected skin was going to be the same as the default site's selected skin, it would not change at all unless you selected it at the site's drop-down menu, then it now became your account's selected skin.
Clarissa Walker []
user/editprefs.php: Finally fix ~20-year-old skin selecting bug! Here was the bug in question: If your future selected skin was going to be the same as the default site's selected skin, it would not change at all unless you selected it at the site's drop-down menu, then it now became your account's selected skin.

3 weeks agoseriesreviews.php: rate-only submissions count toward the series rating (issue #11)
Danilo Stern-Sapad []
seriesreviews.php: rate-only submissions count toward the series rating (issue #11)

The rating UPDATE was gated on the text-review count, which is 0 when
Allow Ratings Only is on, so the recomputed rating never landed. Both
gates (the series and the parent walk) now key on the rating aggregate;
AVG's NULL still keeps the update silent when nothing was rated, and
the ?? 0 in the guarded lines is gone (PHP 5 friendly, see issue #10).

3 weeks agoadmin/panels.php: Undefined array key PHP 8 warning on viewing a panel with null entries and Trying to access array offset on null PHP 8 warning dirty fixes
Clarissa Walker []
admin/panels.php: Undefined array key PHP 8 warning on viewing a panel with null entries and Trying to access array offset on null PHP 8 warning dirty fixes

3 weeks agodefault_tpls/listings.tpl: fix layout lacking a space between the author's name and the selected review rating for the listing of series in the browse page
Clarissa Walker []
default_tpls/listings.tpl: fix layout lacking a space between the author's name and the selected review rating for the listing of series in the browse page

3 weeks agodefault_tpls/storyindex.tpl: fix layout lacking a space between the selected review rating and the print icon in a story's Table of Contents page
Clarissa Walker []
default_tpls/storyindex.tpl: fix layout lacking a space between the selected review rating and the print icon in a story's Table of Contents page

3 weeks agoincludes/corefunctions.php: update javascript stripping regex - from @ariadoss
Clarissa Walker []
includes/corefunctions.php: update javascript stripping regex - from @ariadoss

3 weeks agoheader.php, search.php, includes/- corefunctions.php, upload_class.php: Security - local file inclusion/directory traversal and encode echoed terms patches - from @ariadoss
Clarissa Walker []
header.php, search.php, includes/- corefunctions.php, upload_class.php: Security - local file inclusion/directory traversal and encode echoed terms patches - from @ariadoss

3 weeks agoupdate eFic2eFic bridge and default files
Clarissa Walker []
update eFic2eFic bridge and default files

3 weeks agoadmin/custpages.php: restore trailing space - editor change...
Clarissa Walker []
admin/custpages.php: restore trailing space - editor change...

3 weeks agoincludes/mysqli_functions.php: further disable ONLY_FULL_GROUP_BY setting, partially bring back MYSQL40 compat - a variant of this shows up in newer eFiction 3.5.72
Clarissa Walker []
includes/mysqli_functions.php: further disable ONLY_FULL_GROUP_BY setting, partially bring back MYSQL40 compat - a variant of this shows up in newer eFiction 3.5.72

3 weeks agoheader.php, user.php, user/login.php: Security - Session and Remember Me cookies are now marked httponly and Lax, previously nonexistent - from @ariadoss
Clarissa Walker []
header.php, user.php, user/login.php: Security - Session and Remember Me cookies are now marked httponly and Lax, previously nonexistent - from @ariadoss

3 weeks agoadmin/messages.php: Security - CSRF protection for admin message forms; viewpage.php, admin/custpages.php: Security - do not execute PHP in stored pages and CSRF protection, but delete is a confirmation prompt instead - from @ariadoss
Clarissa Walker []
admin/messages.php: Security - CSRF protection for admin message forms; viewpage.php, admin/custpages.php: Security - do not execute PHP in stored pages and CSRF protection, but delete is a confirmation prompt instead - from @ariadoss

3 weeks agoviewstory.php: Undefined variable warnings while trying to access a nonexistent chapter for an existing story final dirty fix for PHP 8 users
Clarissa Walker []
viewstory.php: Undefined variable warnings while trying to access a nonexistent chapter for an existing story final dirty fix for PHP 8 users

3 weeks agoviewstory.php: Undefined variable warnings while trying to access a nonexistent chapter for an existing story better dirty fix for PHP 8 users
Clarissa Walker []
viewstory.php: Undefined variable warnings while trying to access a nonexistent chapter for an existing story better dirty fix for PHP 8 users

3 weeks agoviewstory.php: Undefined variables while trying to access a nonexistent chapter for an existing story dirty fix for PHP 8 users
Clarissa Walker []
viewstory.php: Undefined variables while trying to access a nonexistent chapter for an existing story dirty fix for PHP 8 users

3 weeks agoreviews.php, series.php, viewstory.php, user/- editbio.php, login.php, profile.php, revres.php: Security - Various takeover patches - from @ariadoss
Clarissa Walker []
reviews.php, series.php, viewstory.php, user/- editbio.php, login.php, profile.php, revres.php: Security - Various takeover patches - from @ariadoss

3 weeks agoadmin.php, browse.php, user.php, includes/get_session_vars.php: Security - SQL injection patches - from @ariadoss
Clarissa Walker []
admin.php, browse.php, user.php, includes/get_session_vars.php: Security - SQL injection patches - from @ariadoss

3 weeks agoincludes/mysqli_functions.php: disable ONLY_FULL_GROUP_BY setting - a variant of this shows up in newer eFiction 3.5.72
Clarissa Walker []
includes/mysqli_functions.php: disable ONLY_FULL_GROUP_BY setting - a variant of this shows up in newer eFiction 3.5.72

3 weeks agoadmin/stories.php: some lines changed from dbassoc to dbfetcharray as the original code called for this
Clarissa Walker []
admin/stories.php: some lines changed from dbassoc to dbfetcharray as the original code called for this

3 weeks agouser/login.php: remove unneeded password bcrypt verify boolean check
Clarissa Walker []
user/login.php: remove unneeded password bcrypt verify boolean check

3 weeks agodocs/config.php, install/install.php: do not interpolate strings in any config.php file - security
Clarissa Walker []
docs/config.php, install/install.php: do not interpolate strings in any config.php file - security

3 weeks agoinstall/install.php: fix case '2' semicolon oversight
Clarissa Walker []
install/install.php: fix case '2' semicolon oversight

3 weeks agoMerge pull request #9 from ariadoss/fix/ratings-abuse-issue8
Clarissa Walker []
Merge pull request #9 from ariadoss/fix/ratings-abuse-issue8

reviews.php: one rating per member per story/series (fixes #8)

3 weeks agoinstall/install.php: Be a bit more paranoid regarding security with variables
Clarissa Walker []
install/install.php: Be a bit more paranoid regarding security with variables

3 weeks agochmod fix
Clarissa Walker []
chmod fix

4 weeks agoblocks/categories/categories.php, includes/storyblock.php: eFiction database function change
Clarissa Walker []
blocks/categories/categories.php, includes/storyblock.php: eFiction database function change

4 weeks agoadmin/genres.php, admin/warnings.php: eFiction database function change - technically not used here, but still...
Clarissa Walker []
admin/genres.php, admin/warnings.php: eFiction database function change - technically not used here, but still...

4 weeks agoincludes/corefunctions.php: Add utf8 shims from eFiction 3.5.72 - solves future PHP 9 deprecation and removal
Clarissa Walker []
includes/corefunctions.php: Add utf8 shims from eFiction 3.5.72 - solves future PHP 9 deprecation and removal

4 weeks agoadmin/stories.php, includes/mysqli_functions.php: Database function changes from eFiction 3.5.72 - keep the MySQL strict mode behavior
Clarissa Walker []
admin/stories.php, includes/mysqli_functions.php: Database function changes from eFiction 3.5.72 - keep the MySQL strict mode behavior

4 weeks agoincludes/storyblock.php: Code formatting
Clarissa Walker []
includes/storyblock.php: Code formatting

4 weeks agoadmin/backup_utf8.php: Properly fix UTF-8 database dump function - from newly released eFiction 3.5.72 codebase
Clarissa Walker []
admin/backup_utf8.php: Properly fix UTF-8 database dump function - from newly released eFiction 3.5.72 codebase

4 weeks agoreviews.php: one rating per member per story/series (issue #8)
Danilo Stern-Sapad []
reviews.php: one rating per member per story/series (issue #8)

A repeat submission by a logged-in member now revises their existing
review row instead of inserting a fresh one and walking the story or
series average. Anonymous submissions keep the old behavior; the edit
path is untouched, so the warnings the earlier POST-side rate check hit
cannot recur. The same guard is going into Hyperion360/efiction.

5 weeks agoUpdate README.md - quite a while...
Clarissa Walker []
Update README.md - quite a while...

5 weeks agoadmin/categories.php: Formatting changes
Clarissa Walker []
admin/categories.php: Formatting changes

5 weeks agoviewuser.php: Formatting goof fix
Clarissa Walker []
viewuser.php: Formatting goof fix

5 weeks agoviewuser.php: Add previously nonexistent check for nonexistent or formerly existing users... oh, and UID 0 - should probably use a better message than the generic database one, though
Clarissa Walker []
viewuser.php: Add previously nonexistent check for nonexistent or formerly existing users... oh, and UID 0 - should probably use a better message than the generic database one, though

5 weeks agoincludes/seriesreviews.php: Make PHP 8 fix more human-readable - part 2
Clarissa Walker []
includes/seriesreviews.php: Make PHP 8 fix more human-readable - part 2

6 weeks agoincludes/mysqli_functions.php: fix copy-paste oversight in security-related MYSQLi set_charset options
Clarissa Walker []
includes/mysqli_functions.php: fix copy-paste oversight in security-related MYSQLi set_charset options

6 weeks agoadmin/mailusers.php: use 'pagetitle' div instead of generic centered div for its title
Clarissa Walker []
admin/mailusers.php: use 'pagetitle' div instead of generic centered div for its title

6 weeks agoheader.php, user/profile.php: Trying to access array on null and Undefined variable PHP warnings dirty fix for trying to access nonexistent or formerly existing user profiles
Clarissa Walker []
header.php, user/profile.php: Trying to access array on null and Undefined variable PHP warnings dirty fix for trying to access nonexistent or formerly existing user profiles

6 weeks agoincludes/seriesreviews.php: Make PHP 8 fix more human-readable
Clarissa Walker []
includes/seriesreviews.php: Make PHP 8 fix more human-readable

6 weeks agoincludes/userlist.php: Remove long-forgotten error suppression 'patch'
Clarissa Walker []
includes/userlist.php: Remove long-forgotten error suppression 'patch'

6 weeks agoinstall/install.php: more formatting consistency
Clarissa Walker []
install/install.php: more formatting consistency

6 weeks agoinstall/install.php: formatting consistency
Clarissa Walker []
install/install.php: formatting consistency

6 weeks agoupdate.php: Refine Archive Conversion panel check - admin/convert_mod, admin/convert_mod_0900.php: Bring Archive Conversion fixes and changes from update.php
Clarissa Walker []
update.php: Refine Archive Conversion panel check - admin/convert_mod, admin/convert_mod_0900.php: Bring Archive Conversion fixes and changes from update.php

6 weeks agoupdate.php: Fix missing tableprefix constant oversight for Archive Conversion panel check
Clarissa Walker []
update.php: Fix missing tableprefix constant oversight for Archive Conversion panel check

6 weeks agoblocks/poll/init.php: SQL engine consistency fix
Clarissa Walker []
blocks/poll/init.php: SQL engine consistency fix

6 weeks agobrowse/categories.php, browse/ratings.php: Add 'no results' message for empty results
Clarissa Walker []
browse/categories.php, browse/ratings.php: Add 'no results' message for empty results

6 weeks agobrowse/class.php: More PHP 8 fixes - Uncaught TypeError, Undefined array key, Trying to access array offset on null
Clarissa Walker []
browse/class.php: More PHP 8 fixes - Uncaught TypeError, Undefined array key, Trying to access array offset on null

7 weeks agoincludes/load-bearing.php: Fix amusing misspelling of the word variable
Clarissa Walker []
includes/load-bearing.php: Fix amusing misspelling of the word variable

7 weeks agoincludes/mysqli_functions.php: add set_charset to query - security-related
Clarissa Walker []
includes/mysqli_functions.php: add set_charset to query - security-related

7 weeks agouser/editbio.php: use eFiction-specific function instead of hardcoded mysqli function for fetching a row to check password length
Clarissa Walker []
user/editbio.php: use eFiction-specific function instead of hardcoded mysqli function for fetching a row to check password length

7 weeks agoadmin/convert.php: Fix warning message showing under the conversion confirmation message - warning should always remain above the confirmation message but below the header
Clarissa Walker []
admin/convert.php: Fix warning message showing under the conversion confirmation message - warning should always remain above the confirmation message but below the header

8 weeks agoUpdate README.md
Clarissa Walker []
Update README.md

8 weeks agobrowse/class.php: fix Uncaught TypeError in PHP 8 with visiting a classification type that has no classifications listed
Clarissa Walker []
browse/class.php: fix Uncaught TypeError in PHP 8 with visiting a classification type that has no classifications listed

8 weeks agovarious block inits: ENGINE from MyISAM -> InnoDB change
Clarissa Walker []
various block inits: ENGINE from MyISAM -> InnoDB change

8 weeks agoCollation change in Classifications sorting/handling
Clarissa Walker []
Collation change in Classifications sorting/handling

8 weeks agoAllowDynamicTemplates flag -> official PHP variant
Clarissa Walker []
AllowDynamicTemplates flag -> official PHP variant

8 weeks agoblocks/recent/admin.php: Slight tweak on submit button positioning
Clarissa Walker []
blocks/recent/admin.php: Slight tweak on submit button positioning

8 weeks agoadmin/ratings.php: Formatting changes
Clarissa Walker []
admin/ratings.php: Formatting changes

8 weeks agoadmin/characters.php: Formatting changes
Clarissa Walker []
admin/characters.php: Formatting changes

8 weeks agoblocks/shoutbox/admin.php: Formatting changes
Clarissa Walker []
blocks/shoutbox/admin.php: Formatting changes

8 weeks agoblocks/countdown/admin.php: Formatting changes
Clarissa Walker []
blocks/countdown/admin.php: Formatting changes

8 weeks agoblocks/news/admin.php: Formatting changes
Clarissa Walker []
blocks/news/admin.php: Formatting changes

8 weeks agoblocks/login/admin.php: Slight tweak on tinyMCE toggle checkbox set
Clarissa Walker []
blocks/login/admin.php: Slight tweak on tinyMCE toggle checkbox set

8 weeks agoblocks/login/admin.php: Formatting changes
Clarissa Walker []
blocks/login/admin.php: Formatting changes

8 weeks agoblocks/random/admin.php: Formatting changes
Clarissa Walker []
blocks/random/admin.php: Formatting changes

8 weeks agoblocks/featured/admin.php: Formatting changes
Clarissa Walker []
blocks/featured/admin.php: Formatting changes

8 weeks agoblocks/recent/admin.php: Formatting changes
Clarissa Walker []
blocks/recent/admin.php: Formatting changes

8 weeks agoadmin/blocks.php: remove original variable fix as the issue was actually at blocks/menu/menu.php... Though I had no clue the original fix was done in the e107 forked version as well...
Clarissa Walker []
admin/blocks.php: remove original variable fix as the issue was actually at blocks/menu/menu.php... Though I had no clue the original fix was done in the e107 forked version as well...

8 weeks agoviewstory.php: Typo fix
Clarissa Walker []
viewstory.php: Typo fix

8 weeks agoUpdate README.md
Clarissa Walker []
Update README.md

2 months agoviewseries.php: Add previously nonexistent check for nonexistent series, otherwise PHP warnings appear - copied from viewstory.php and edited for this page
Clarissa Walker []
viewseries.php: Add previously nonexistent check for nonexistent series, otherwise PHP warnings appear - copied from viewstory.php and edited for this page

2 months agoreviews.php: Have no one try and create reviews to nonexistent stories and series - previous null patches stay, however
Clarissa Walker []
reviews.php: Have no one try and create reviews to nonexistent stories and series - previous null patches stay, however

2 months agoreviews.php: forgotten coauthors revert
Clarissa Walker []
reviews.php: forgotten coauthors revert

2 months agoMod Conversion page reorganization - also with a warning message
Clarissa Walker []
Mod Conversion page reorganization - also with a warning message

2 months agoadmin/backup_utf8.php: Fix double-encoding database dump in script - was doing ISO-8859-1 -> UTF-8 -> ISO-8859-1
Clarissa Walker []
admin/backup_utf8.php: Fix double-encoding database dump in script - was doing ISO-8859-1 -> UTF-8 -> ISO-8859-1

2 months agoincludes/plain.button.php: PHP 8.x fixes just for fun
Clarissa Walker []
includes/plain.button.php: PHP 8.x fixes just for fun