Use [[fallthrough]] attribute.

Minor change to use constexpr.

Use std::filesystem::path for reading/writing files.

Also remove fstream_wfopen.h as it is no longer needed.
Also make XSFFile not store the string of the path but store the path as std::filesystem::path.

Add warnings to building with GCC/Clang.

* These were mostly copied from the old Makefile.
* The files including wxWidgets need -Wno-old-style-cast done in the code via pragmas because I do not want to disable that warning for the rest of the files. (It might've been overkill for some places where wxWidgets was included, but whatever.)

Add wxWidgets-based configuration dialog boxes.

* Removes the configuration dialog boxes that used my DialogBuilder.
* Move default configuration values to be inlined within the headers.
* Moved 2SF's and GSF's XSFConfig classes to their own headers to accommodate the new wxWidgets dialog boxes.
* Make it so NCSF's SoundView dialog can be toggled on or off from the configuration dialog box.

Replace #ifdef _DEBUG with #ifndef NDEBUG

Add override keyword.

Minor changes to the RegEx validator.

Also add the RegEx validator to the CMake script.

Add a RegEx validator for use with wxWidgets.

Silence various Visual Studio warnings:

* Fix the ones in my code where I could use a proper type or valid casts.
* Ignore the designer-time and compiler-time warnings in vendor code or in my code where I am unable to suppress them via casting.
(Most of these were ignored already before introducing the CMake scripts, because they were in vendor code or were annoying to deal with.)

Make it so zlib's submodule being dirty is ignored.

(This is because of what I mentioned in the last commit, where zlib's CMake script modifies a file in the submodule.)

Add CMake scripts in preparation for wxWidgets changes.

(One downside here, zlib's CMake script renames its zconf.h... which in turn means that the submodule now thinks there are uncommitted changes. :/)

Add submodule for wxWidgets.

This is in preparation for replacing my DialogBuilder with wxWidgets for the configuration dialog boxes. DialogBuilder will still be included for now for the currently unused info dialog boxes.

Add 3-clause BSD license to the repo.

Fix warning about invalid index.

Ignore Visual Studio warning about using GetTickCount().

(The only way to use GetTickCount64() would be to change the Windows version target up from 2000 to Vista.)

Turns out that the trailing return type isn't actually needed here.

Missed a uint32_t -> std::uint32_t.

Rename SBNKInstrument(Range) to SBNKInstrument(Entry).

(SBNKInstrument -> SBNKInstrumentEntry and SBNKIntrumentRange -> SBNKInstrument)
The old names didn't really make much sense when I started porting the creation tools code to C#, so might as well fix them here too.

Various changes:

* Use enum class instead of enum (except for the enums for the resource IDs, not really necessary there).
* For NCSF specifically, included a function to convert an enum class to its underlying integral type (as this is needed for use with the std::bitset class).
* Cleanup headers so all the ones needed in a file are explicitly included even if they may possibly be included in another header.
* Used forward declarations in a few spots.
* Explicitly namespaced all (u)int*_t uses (this might seem like overkill, but it helps me see when the standard types are being used with a simple search for std::).
* Made sure it all builds with MinGW-w64 as well (both gcc and clang).
* Removed some std::move from DialogBuilder.cpp based on clang's warnings for that.
* Replaced use of std::copy_n on strings in DialogBuilder.cpp with my CopyToString functions that use wcscpy.
* Replaced CHAR_MIN/CHAR_MAX in eqstr.h and ltstr.h with std::numeric_limits<char>::min/max().

Replaced the SDAT record types enum with constants.

Correct a few warnings Visual Studio was complaining about.

Cleanup a few comments and strings.

Use C++17 std::filesystem functions instead of my own.

Remove now unnecessary using std::placeholders.

Replace std::rand with RNG based on actual DS RNG.

(This also means the playback of songs with randomness in them will be deterministic now.)

Correct size of file ID in INFOEntry structures to 32-bit.

Replace std::not1 with a lamba.

Ignore Visual Studio 2019's warning about using TerminateThread.

Use std::make_unique where possible.

Remove some now unnecessary codecvt lines.

Move TagList's code to get tag order into its own function.

Also uses a lambda instead of binding.

Ignore Visual Studio 2019's arithmetic overflow warning.

It is obnoxious and only in the IDE and not at compile-time.

Replace memcpy/memset with std::copy_n/std::fill_n.

Correct typos in the function names in the loads of GSF and SNSF.

(This probably came about from copying the code from the 2SF player and not fixing the names.)

Remove the copy constructors from SBNK, SDAT and SSEQ.

(They were probably holdovers from copying the code from the NCSF creation tools.)

A few more conversion changes:

* To go along with the previous change, XSFConfig now had internal get/set value functions that use type traits to choose between the enum and non-enum versions. (This also means I do not need to manually double-cast enums now.)
* Fix bug with the Windows API string conversions, so they do not include the trailing null byte in the output string.
* Added function to trim trailing 0s (and the decimal point if necessary) from a string that came from a double.

Some conversion replacements:

* Replace the (w)stringify functions with the standard std::to_(w)string functions.
* Replace convertTo with versions that use type_traits to determine which standard string conversion function to call, as well as handle enums specically.

Replace deprecated wstring_convert with Windows API functions.

Remove last modification date from files.

(I never remember to update these and besides, GitHub history can show when they were last modified.)

Various updates:

* Fix build with Visual Studio, updating projects to Visual Studio 2019 (as that is what I have installed).
* Changed C++ language standard to C++ 17.
* Add files for in_2sf's spu from Coda's recent commit.
* Add files for zlib now that it is being included as a submodule (removes the need for the zlib DLL as well).
* Remove common.props (due to the aforementioned zlib inclusion as well as the winamp headers also being in the project now).
* Minor NCSF file in the SSEQ player, the check for when to process tracks should've been >=, not >.

Merge pull request #5 from ahigerd/master

Update for modern compilers, update 2sf core, add MSVC cross-compile support

use .PHONY instead of FORCE

switch to git submodule for zlib

2sf: fix JIT enable, fix sample rate

fix mingw build, clean up new warnings

add sharp interpolator option, fix makefile dependencies

update for C++17 compliance, update to latest 2sf, add WINE cross-compile makefiles

[Framework] Super minor cleanups.

[NCSF] Super minor cleanups.

[NCSF] Minor possible fix in sample increment

* While I am unsure if this would've ever happened, this will prevent the locations from being out-of-bounds.

[NCSF] Enable portamento when setting those registers.

(Thanks to Coda Highland for the fix.)

[NCSF] <stdexcept> is actually needed...

(It probably never triggered any errors in the past because of it being implicitly included by some other header file.)

[NCSF] Fix PSG output.

* Changed the base timer and actually utilize the note number from the note definition even for PSG. Thanks to Kurausukun for informing me about the issue and helping to provide a sample to demonstrate the issue.
* Correct the frequency output in the debug sound view (using DeSmuME's method directly resulted in frequencies that were 3 octaves higher than what they should have been).

[NCSF] Small typo (or rather non-removal) in the previous fix

Merge remote-tracking branch 'origin/master'

Prevent .vs from being committed

[NCSF] Apply channel modulation fix from fincs

Merge pull request #2 from zeromus/patch-1

Update XSFPlayer_2SF.cpp

Update XSFPlayer_2SF.cpp

Make it substantially more obvious how to hack the 2sf player to output at a different samplerate by removing the secret implicit 44100 based calculation

[NCSF] Update version and README for the previous change.

Fix unsigned underflow with a loop offset of 0 on an ADPCM SWAV.

Also a minor optimization when reading the SWAVs.

[NCSF] Update README file for the previous 2 commits.

[NCSF] Applied sinc modification from kode54:

Sinc mode should not scale the window, just the sinc pulse.

[NCSF] Utilize the PLAYER blocks in the SDAT if they exist.

Backwards compatibility is kept by treating the lack of PLAYER info as
if all channels are able to be allocated.

[NCSF] Very minor cleanups.

[2SF] A few commits from the asmjit project.

[NCSF] Bump version number for the previous fixes.

Adding a .gitignore to stop git from trying to version certain files.

[NCSF] Documented what FSS functions were originally used.

* Changed default of modDelay to 0.
* Also minor cleanup.

[NCSF] Reversed the order of the PSG and Noise channel allocations.

This was suggested by fincs as the proper way to fix channels being
cutoff incorrectly.
(Also moved volume assignment so it was less duplicated.)

[NCSF] Changed sinc interpolation to a Nuttall 3-term Window on suggestion from kode54.

[NCSF] Fixed unintentional infinite loop in the previous attack rate calculation fix.

[NCSF] Changes to the Sound View debug window:
* No longer has the hold/busy items.
* Source Address replaced with State.

[NCSF] Partial fix to channels being unintentionally cut off.

[NCSF] Minor correction to the attack rate calculation.

(Basically, it should never allow the same volume level as the previous
calculation.)

[NCSF] Corrected attack rate calculation.

[NCSF] Minor edit with the debug Sound View so it doesn't use a reference.

[NCSF] Bump version number for the previous volume fixes.

[NCSF] One more volume fix, the default volume is 127, not 64.

[NCSF] Correctly handle the SSEQ volume from the INFO block.

[NCSF] REALLY remove minor instance of variable shadowing.

[NCSF] Remove minor instance of variable shadowing.

[NCSF] Move track allocation into the SSEQ command handler.

This was suggested by fincs after I found some sequences that appeared
to do track allocations later in them than expected originally.

[NCSF] Minor code changes to reduce code duplication.

* Made a function in the Override struct to centralize where it
determines whether to use the override value or not.
* Made a function that returns the number of bytes that a command needs,
and used that to remove all the conditionals for processing a command to
instead handle that within the IF command itself.
Thanks to fincs and Henke37 for the suggestions to do this.

[NCSF] Implemented the random, variable, and conditional commands. Also fixed loop counter.

Reverted the sound changes back to the original FSS code, but with the fix to clamp the total volume.

Also commented out the code that uses the SSEQ's volume, it seems as if
the DS doesn't use it so I probably shouldn't be using it either.

[NCSF] Removed the Cnv_Scale function as it seemed to cause sounds to be too loud in some cases.

[NCSF] Fix volume issues with a little help from the Nintendo DS SDK.

Also added a clone of DeSmuME's Sound View that is only build during a
debug build, which helped to identify the above issues.

Made note of update to zlib 1.28. (Should actually say 1.2.8, but I'll fix that in the future.)

[NCSF] Should've updated the version number before.

[NCSF] Minor comment fix from the previous NCSF commit.

[2SF] Update from asmjit.

[NCSF] Interpolation changes:

* Removed Cosine, 4-Point B-Spline, 6-Point B-Spline, and 6-point
Osculating.
* Added 4-Point Legrange and 6-Point Legrange.
* Changed wording of the Sinc interpolation to mention that it is
16-point.

Removing this file as it doesn't help since common.props is already tracked, trying another route.

Trying to get git to ignore changes I make to common.props in the future (have to be able to change it to build the DLLs).

This should've never got committed as it was, oops.

* Small Makefile changes.

* Removed a couple files that were not being used.
* Cleanups found with clang's -Weverything (and shutting it up about a
lot of things that were ridiculous, as well as ignoring some of the
warnings still coming up).

[2SF] Minor edit of a preprocessor line.