reviews.php, series.php, viewstory.php, user/- editbio.php, login.php, profile.php, revres.php: Security - Various takeover patches - from @ariadoss
--- a/reviews.php
+++ b/reviews.php
@@ -145,6 +145,8 @@
else {
$output .= write_message(_REVTHANKYOU);
if($action == "edit") {
+ list($revuid) = dbrow(dbquery("SELECT uid FROM ".TABLEPREFIX."fanfiction_reviews WHERE reviewid = '$reviewid' LIMIT 1"));
+ if(!isADMIN && (int)$revuid !== (int)USERUID) accessDenied( );
$update = dbquery("UPDATE ".TABLEPREFIX."fanfiction_reviews SET review = '$review', rating = '$rating' WHERE reviewid = '$reviewid' LIMIT 1");
$info = dbquery("SELECT item, type, chapid FROM ".TABLEPREFIX."fanfiction_reviews WHERE reviewid = '$reviewid' LIMIT 1");
list($item, $type, $chapid) = dbrow($info);
--- a/series.php
+++ b/series.php
@@ -114,7 +114,10 @@
$title = replace_naughty($title);
$summary = replace_naughty($summary);
if($action == "edit") {
+ if(!isset($_POST['seriesid']) || !isNumber($_POST['seriesid'])) accessDenied( );
$seriesid = $_POST['seriesid'];
+ list($seriesowner) = dbrow(dbquery("SELECT uid FROM ".TABLEPREFIX."fanfiction_series WHERE seriesid = '$seriesid' LIMIT 1"));
+ if(!$admin && $seriesowner != USERUID) accessDenied( );
dbquery("UPDATE ".TABLEPREFIX."fanfiction_series SET title = '$title', summary ='$summary', catid = '$category', isopen = '$open', characters = '$charid', classes = '$classes' WHERE seriesid = '$seriesid'");
$codequery = dbquery("SELECT * FROM ".TABLEPREFIX."fanfiction_codeblocks WHERE code_type = 'editseries'");
while($code = dbassoc($codequery)) {
--- a/user/editbio.php
+++ b/user/editbio.php
@@ -46,7 +46,8 @@
$uid = isset($_REQUEST['uid']) ? $_REQUEST['uid'] : false;
if(!$uid) $uid = USERUID;
- if((!isADMIN || uLEVEL > 2) && $uid != USERUID && $action == "editbio") $output .= write_error(_NOTAUTHORIZED);
+ if($uid && !isNumber($uid)) accessDenied( );
+ if((!isADMIN || uLEVEL > 2) && $uid != USERUID && $action == "editbio") accessDenied( );
if(isMEMBER) $output .= "<div id=\"pagetitle\">"._EDITPERSONAL."</div>";
else $output .= "<div id=\"pagetitle\">"._NEWACCOUNT."</div>";
@@ -174,7 +175,7 @@
$output .= write_message(_PENNAMEINUSE." "._TRYAGAIN);
}
else {
- dbquery("UPDATE "._AUTHORTABLE." SET penname = '".escapestring($penname)."' WHERE uid = '$_POST[uid]'");
+ dbquery("UPDATE "._AUTHORTABLE." SET penname = '".escapestring($penname)."' WHERE uid = '$uid'");
if($logging) dbquery("INSERT INTO ".TABLEPREFIX."fanfiction_log (`log_action`, `log_uid`, `log_ip`, `log_type`, `log_timestamp`) VALUES('".escapestring(sprintf(_NEWPEN, USERPENNAME, USERUID, $_POST['oldpenname'], $uid, $penname))."', '".USERUID."', INET6_ATON('".$_SERVER['REMOTE_ADDR']."'), 'EB', " . time() . ")");
}
}
@@ -217,8 +218,8 @@
else if(isset($user)) $output .= " ".$user['penname'];
$output .= "</div>
- <div><label for='realname'>"._REALNAME.": </label><INPUT type=\"text\" class=\"textbox=\" name=\"realname\" maxlength=\"200\" value=\"".(isset($user) ? $user['realname'] : "")."\"></div>
- <div><label for='email'>"._EMAIL.":</label><INPUT type=\"text\" class=\"textbox=\" name=\"email\" value=\"".(isset($user) ? $user['email'] : "")."\" maxlength=\"200\" size=\"35\"><font color=\"red\">*</font></div>
+ <div><label for='realname'>"._REALNAME.": </label><INPUT type=\"text\" class=\"textbox=\" name=\"realname\" maxlength=\"200\" value=\"".(isset($user) ? htmlspecialchars($user['realname'], ENT_QUOTES) : "")."\"></div>
+ <div><label for='email'>"._EMAIL.":</label><INPUT type=\"text\" class=\"textbox=\" name=\"email\" value=\"".(isset($user) ? htmlspecialchars($user['email'], ENT_QUOTES) : "")."\" maxlength=\"200\" size=\"35\"><font color=\"red\">*</font></div>
<div><label for='bio'>"._BIO.":</label></div>
<div style='width: 450px; margin: 0 auto;'>
<textarea class=\"textbox\" name=\"bio\" cols=\"50\" rows=\"6\">".(isset($user['bio']) ? stripslashes($user['bio']) : "")."</TEXTAREA></div>";
--- a/user/login.php
+++ b/user/login.php
@@ -71,6 +71,7 @@
setcookie($sitekey."_salt", md5($passwd['email'] . $encryptedpasswordb), time()+60*60*24*30, "/");
}
if(!isset($_SESSION)) session_start( );
+ session_regenerate_id(true);
$_SESSION[$sitekey."_useruid"] = $passwd['uid'];
$_SESSION[$sitekey."_salt"] = md5($passwd['email'] . $encryptedpasswordb);
$logincode = dbquery("SELECT * FROM ".TABLEPREFIX."fanfiction_codeblocks WHERE code_type = 'login'");
@@ -85,6 +86,7 @@
setcookie($sitekey."_salt", md5($passwd['email'] . $encryptedpasswordm), time()+60*60*24*30, "/");
}
if(!isset($_SESSION)) session_start( );
+ session_regenerate_id(true);
$_SESSION[$sitekey."_useruid"] = $passwd['uid'];
$_SESSION[$sitekey."_salt"] = md5($passwd['email'] . $encryptedpasswordm);
$logincode = dbquery("SELECT * FROM ".TABLEPREFIX."fanfiction_codeblocks WHERE code_type = 'login'");
--- a/user/profile.php
+++ b/user/profile.php
@@ -46,7 +46,7 @@
$tpl->assign("bio", stripslashes($bio));
}
if(isset($userinfo['image']))
- $tpl->assign("image", "<img src=\"".$userinfo['image']."\">");
+ $tpl->assign("image", "<img src=\"".htmlspecialchars($userinfo['image'], ENT_QUOTES)."\">");
$tpl->assign("userlevel", isset($userinfo['level']) && $userinfo['level'] > 0 && $userinfo['level'] < 4 ? _ADMINISTRATOR.(isADMIN ? " - ".$userinfo['level'] : "") : _MEMBER);
--- a/user/revres.php
+++ b/user/revres.php
@@ -26,10 +26,11 @@
$output .= "<div id=\"pagetitle\">"._MANAGEREVIEWS."</div>";
if(isset($_POST['submit'])) {
- $reviewid = isset($_POST['reviewid']) && isNumber($_POST['reviewid']) ? $_POST['reviewid'] : false;
- $result = dbquery("SELECT review, reviewid, item, type, chapid, uid FROM ".TABLEPREFIX."fanfiction_reviews WHERE reviewid = '".$_POST['rid']."' LIMIT 1");
+ $reviewid = isset($_POST['rid']) && isNumber($_POST['rid']) ? $_POST['rid'] : false;
+ if(!$reviewid) accessDenied( );
+ $result = dbquery("SELECT review, reviewid, item, type, chapid, uid FROM ".TABLEPREFIX."fanfiction_reviews WHERE reviewid = '$reviewid' LIMIT 1");
list($review, $reviewid, $item, $type, $chapid, $uid) = dbrow($result);
- $updated = escapestring($review . "<br><br><i>"._AUTHORSRESPONSE.": " .replace_naughty(descript($_POST['response'], $allowed_tags))."</i>");
+ $updated = escapestring($review . "<br><br><i>"._AUTHORSRESPONSE.": " .replace_naughty(descript(strip_tags($_POST['response'], $allowed_tags)))."</i>");
$success = dbquery("UPDATE ".TABLEPREFIX."fanfiction_reviews SET review = '$updated', respond = '1' WHERE reviewid = '$reviewid'");
if($uid) {
$prefsquery = dbquery("SELECT "._UIDFIELD." as uid, "._EMAILFIELD." as email, "._PENNAMEFIELD." as penname, newrespond FROM ".TABLEPREFIX."fanfiction_authorprefs as ap LEFT JOIN "._AUTHORTABLE." ON ap.uid = "._UIDFIELD." WHERE ap.uid = "._UIDFIELD." AND "._UIDFIELD." = '$uid' LIMIT 1");
--- a/viewstory.php
+++ b/viewstory.php
@@ -226,7 +226,7 @@
eval($code['code_text']);
}
include("includes/storyblock.php");
- $printicon = "<a href=\"viewstory.php?action=printable&textsize=$textsize&sid=$sid&chapter=all\" target=\"_blank\"><img src='".(isset($printer) ? $printer : "images/print.gif")."' border='0' alt='"._PRINTER."'></a>";
+ $printicon = "<img src='".(isset($printer) ? $printer : "images/print.gif")."' border='0' alt='"._PRINTER."'> <a href=\"viewstory.php?action=printable&textsize=$textsize&sid=$sid&chapter=all\" target=\"_blank\">"._STORY."</a>";
if($reviewsallowed && (isMEMBER || $anonreviews))
$reviewslink = "<a href=\"reviews.php?action=add&item=$sid&next=2&type=ST\">"._SUBMITREVIEW."</a>";
$tpl->assign( "reviewslink", $reviewslink );
@@ -248,7 +248,7 @@
$tpl->assign("chapternumber", $chap['inorder']);
$tpl->assign("title", "<a href=\"viewstory.php?sid=$sid&chapter=".$chap['inorder']."\">".$chap['title']."</a>");
$tpl->assign("author", "<a href='viewuser.php?uid=".$chap['uid']."'>".$chap['penname']."</a>");
- $tpl->assign("printicon", "<a href=\"viewstory.php?action=printable&textsize=$textsize&sid=$sid&chapter=".$chap['inorder']."\" target=\"_blank\"><img src='".(isset($printer) ? $printer : "images/print.gif")."' border='0' alt='"._PRINTER."'></a>");
+ $tpl->assign("printicon", "<img src='".(isset($printer) ? $printer : "images/print.gif")."' border='0' alt='"._PRINTER."'> <a href=\"viewstory.php?action=printable&textsize=$textsize&sid=$sid&chapter=".$chap['inorder']."\" target=\"_blank\">"._STORY."</a>");
$tpl->assign("ratingpics", ratingpics($chap['rating']));
if($reviewsallowed) {
$tpl->assign("reviews", "<a href=\"reviews.php?type=ST&item=$sid&chapid=".$chap['chapid']."\">"._REVIEWS."</a>");
@@ -343,7 +343,7 @@
while($code = dbassoc($codeblocks)) {
eval($code['code_text']);
}
- $printicon = "<a href=\"viewstory.php?action=printable&sid=$sid&textsize=$textsize&chapter=1\" target=\"_blank\"><img src='".(isset($printer) ? $printer : "images/print.gif")."' border='0' alt='"._PRINTER."'></a>";
+ $printicon = "<img src='".(isset($printer) ? $printer : "images/print.gif")."' border='0' alt='"._PRINTER."'> <a href=\"viewstory.php?action=printable&sid=$sid&textsize=$textsize&chapter=1\" target=\"_blank\">"._STORY."</a>";
}
// if the *CHAPTER* hasn't been validated and the viewer isn't an admin or the author throw them a warning.
if(!$valid && !isADMIN && USERUID != $chapterauthor && !in_array($chapterauthor, $storyinfo['coauthors'])) {