news.php, reviews.php: Some dirty fixes for PHP warnings are no longer needed since the checks, but three more are used in reviews.php for item 0
--- a/news.php
+++ b/news.php
@@ -90,17 +90,17 @@
$news->newBlock("newsbox");
//assign values
- $news->assign("newstitle" , stripslashes(isset($stories['title']) ? $stories['title'] : null) );
- $news->assign("newsstory" , format_story(isset($stories['story']) ? $stories['story'] : null) );
- $news->assign("newsauthor", stripslashes(isset($stories['author']) ? $stories['author'] : null) );
- $news->assign("newsid", (isset($stories['nid']) ? $stories['nid'] : null) );
+ $news->assign("newstitle" , stripslashes($stories['title']) );
+ $news->assign("newsstory" , format_story($stories['story']) );
+ $news->assign("newsauthor", stripslashes($stories['author']) );
+ $news->assign("newsid", $stories['nid']);
$news->assign("oddeven", "odd");
$news->assign("skindir", $skindir);
- $news->assign("newsdate", date("$dateformat $timeformat", (isset($stories['date']) ? $stories['date'] : null) ) );
+ $news->assign("newsdate", date("$dateformat $timeformat", $stories['date']) );
if($newscomments)
- $news->assign("newscomments", "<a href=\"news.php?action=newsstory&nid=".(isset($stories['nid']) ? $stories['nid'] : null)."\">".(isset($stories['comments']) ? $stories['comments'] : null)." "._COMMENTS."</a>");
+ $news->assign("newscomments", "<a href=\"news.php?action=newsstory&nid=".$stories['nid']."\">".(isset($stories['comments']) ? $stories['comments'] : null)." "._COMMENTS."</a>");
if(isADMIN && uLEVEL < 4)
- $news->assign("adminoptions", "<a href=\"admin.php?action=news&form=".(isset($stories['nid']) ? $stories['nid'] : null)."\">"._EDIT."</a> | <a href=\"admin.php?action=news&delete=".(isset($stories['nid']) ? $stories['nid'] : null)."\">"._DELETE."</a>");
+ $news->assign("adminoptions", "<a href=\"admin.php?action=news&form=".$stories['nid']."\">"._EDIT."</a> | <a href=\"admin.php?action=news&delete=".$stories['nid']."\">"._DELETE."</a>");
$output .= $news->getOutputContent( );
$cquery = dbquery("SELECT COUNT(cid) FROM ".TABLEPREFIX."fanfiction_comments WHERE nid = '$nid'");
--- a/reviews.php
+++ b/reviews.php
@@ -289,7 +289,7 @@
list($type, $item) = dbrow(dbquery("SELECT type, item FROM ".TABLEPREFIX."fanfiction_reviews WHERE reviewid = '$reviewid' LIMIT 1"));
}
if($type == "ST") {
- $storyquery = dbquery("SELECT s.title, s.uid, s.rid, s.sid, s.coauthors FROM ".TABLEPREFIX."fanfiction_stories as s WHERE s.sid = '$item' LIMIT 1");
+ $storyquery = dbquery("SELECT s.title, s.uid, s.rid, s.sid, s.coauthors FROM ".TABLEPREFIX."fanfiction_stories as s WHERE s.sid = '".(isset($item) ? $item : null)."' LIMIT 1");
$story = dbassoc($storyquery);
$title = title_link($story);
$authoruid = (isset($story['uid']) ? $story['uid'] : null);
@@ -302,10 +302,10 @@
}
}
else if($type == "SE") {
- $storyquery = dbquery("SELECT title, uid FROM ".TABLEPREFIX."fanfiction_series WHERE seriesid = '$item' LIMIT 1");
+ $storyquery = dbquery("SELECT title, uid FROM ".TABLEPREFIX."fanfiction_series WHERE seriesid = '".(isset($item) ? $item : null)."' LIMIT 1");
list($title, $authoruid) = dbrow($storyquery);
$titletext = $title;
- $title = "<a href=\"series.php?seriesid=$item\">".stripslashes($title)."</a>";
+ $title = "<a href=\"series.php?seriesid=".(isset($item) ? $item : null)."\">".stripslashes($title)."</a>";
if(empty($title && $authoruid)) accessDenied();
}
else {
@@ -375,11 +375,11 @@
}
$jumpmenu = "<form name=\"jump\" action=\"\">";
$jumpmenu .= "<select name=\"sid\" onChange=\"window.location=this.options[this.selectedIndex].value\">";
- $jumpmenu .= "<option value=\"reviews.php?type=ST&item=".(isset($story['sid']) ? $story['sid'] : null).(isset($_GET['unresponded']) ? "&unresponded=1" : "")."\"";
+ $jumpmenu .= "<option value=\"reviews.php?type=ST&item=".$story['sid'].(isset($_GET['unresponded']) ? "&unresponded=1" : "")."\"";
if(!isset($chapid))
$jumpmenu .= " selected";
$jumpmenu .= ">"._VIEWALLREVIEWS."</option>";
- $chapquery = dbquery("SELECT inorder, title, chapid, sid FROM ".TABLEPREFIX."fanfiction_chapters WHERE sid = '".(isset($story['sid']) ? $story['sid'] : null)."' ORDER BY inorder ASC");
+ $chapquery = dbquery("SELECT inorder, title, chapid, sid FROM ".TABLEPREFIX."fanfiction_chapters WHERE sid = '".$story['sid']."' ORDER BY inorder ASC");
while($chapters = dbassoc($chapquery)) {
$jumpmenu .= "<option value=\"reviews.php?chapid=".$chapters['chapid'].(isset($_GET['unresponded']) ? "&unresponded=1" : "")."&type=ST&item=$item\"";