blocks/menu/- admin.php, menu.php: further PHP fixes - undefined index notices (PHP 7.x)/undefined array key warnings (PHP 8.x), assumed unserialize() index/array warning and deprecation of false to array conversion in admin panel - this occurs in two scenarios: an entirely new install (menu entry's block_variables are empty on a new install), and with some skins that do not utilize a menu block array in their variables.php file (or don't even have a variables.php file at all)
--- a/blocks/menu/admin.php
+++ b/blocks/menu/admin.php
@@ -54,7 +54,10 @@
if($admin){
$blockquery = dbquery("SELECT * FROM ".TABLEPREFIX."fanfiction_blocks WHERE block_name = '$admin'");
while($block = dbassoc($blockquery)) {
- $blocks[$block['block_name']] = unserialize($block['block_variables']);
+ if ($block['block_variables'])
+ {
+ $blocks[$block['block_name']] = unserialize($block['block_variables']);
+ }
$blocks[$block['block_name']]['title'] = $block['block_title'];
$blocks[$block['block_name']]['file'] = $block['block_file'];
$blocks[$block['block_name']]['status'] = $block['block_status'];
@@ -85,3 +88,4 @@
</select><br /><br /><INPUT type=\"submit\" class=\"button\" name=\"submit\" value=\""._SUBMIT."\"></div></form></div>";
}
?>
+
--- a/blocks/menu/menu.php
+++ b/blocks/menu/menu.php
@@ -14,7 +14,7 @@
else {
$pages = array('home', 'recent', 'titles', 'catslink', 'series', 'members', 'authors', 'challenges', 'search', 'tens', 'featured', 'help', 'contactus', 'login', 'logout', 'adminarea');
foreach($pages as $page) {
- if(!is_null($pagelinks[$page]) || empty($pagelinks[$page])) continue;
+ if(!is_null($page) || empty($pagelinks[$page])) continue;
if(empty($blocks[$block]['style'])) $content .= "<li ".($current == $page ? "id=\"menu_current\"" : "").">".$pagelinks[$page]['link']."</li>";
else $content .= $pagelinks[$page]['link'];
}