header.php, user/profile.php: Trying to access array on null and Undefined variable PHP warnings dirty fix for trying to access nonexistent or formerly existing user profiles
--- a/header.php
+++ b/header.php
@@ -229,7 +229,7 @@
//header("Content-Disposition: inline; filename=\"".$titleinfo."\"");
}
}
-if($current == "viewuser" && isNumber($uid)) {
+if($current == "viewuser" && (isNumber($uid ?? null))) {
$author = dbquery("SELECT "._PENNAMEFIELD." as penname FROM "._AUTHORTABLE." WHERE "._UIDFIELD." = '".$uid."'");
list($penname) = dbrow($author);
$titleinfo = "$sitename :: $penname";
--- a/user/profile.php
+++ b/user/profile.php
@@ -29,23 +29,23 @@
$result2 = dbquery("SELECT *, date as date FROM "._AUTHORTABLE." LEFT JOIN ".TABLEPREFIX."fanfiction_authorprefs as ap ON ap.uid = "._UIDFIELD." WHERE "._UIDFIELD." = '$uid' LIMIT 1");
$userinfo = dbassoc($result2);
$nameinfo = "";
-if($userinfo['email'])
+if(isset($userinfo['email']))
$nameinfo .= " [<a href=\"viewuser.php?action=contact&uid=".$userinfo['uid']."\">"._CONTACT."</a>]";
-if(!empty($favorites) && isMEMBER && $userinfo['uid'] != USERUID) {
- $fav = dbquery("SELECT * FROM ".TABLEPREFIX."fanfiction_favorites WHERE uid = '".USERUID."' AND type = 'AU' AND item = '".$userinfo['uid']."'");
- if(dbnumrows($fav) == 0) $nameinfo .= " [<a href=\"user.php?action=favau&uid=".USERUID."&add=".$userinfo['uid']."\">"._ADDAUTHOR2FAVES."</a>]";
+if(!empty($favorites) && isMEMBER && isset($userinfo['uid']) != USERUID) {
+ $fav = dbquery("SELECT * FROM ".TABLEPREFIX."fanfiction_favorites WHERE uid = '".USERUID."' AND type = 'AU' AND item = '".(isset($userinfo['uid']))."'");
+ if(dbnumrows($fav) == 0) $nameinfo .= " [<a href=\"user.php?action=favau&uid=".USERUID."&add=".(isset($userinfo['uid']))."\">"._ADDAUTHOR2FAVES."</a>]";
}
-$tpl->assign("userpenname", $userinfo['penname']." ".$nameinfo);
-$tpl->assign("membersince", date("$dateformat", $userinfo['date']));
+$tpl->assign("userpenname", ($userinfo['penname'] ?? null)." ".$nameinfo);
+$tpl->assign("membersince", date("$dateformat", ($userinfo['date'] ?? null)));
-if($userinfo['realname'])
+if(isset($userinfo['realname']))
$tpl->assign("realname", $userinfo['realname']);
-if($userinfo['bio']) {
+if(isset($userinfo['bio'])) {
$bio = nl2br($userinfo['bio']);
$tpl->assign("bio", stripslashes($bio));
}
-if($userinfo['image'])
+if(isset($userinfo['image']))
$tpl->assign("image", "<img src=\"".$userinfo['image']."\">");
$tpl->assign("userlevel", isset($userinfo['level']) && $userinfo['level'] > 0 && $userinfo['level'] < 4 ? _ADMINISTRATOR.(isADMIN ? " - ".$userinfo['level'] : "") : _MEMBER);
@@ -86,7 +86,7 @@
$adminopts = "";
if(isADMIN && uLEVEL < 3) {
$adminopts .= "<div class=\"adminoptions\"><span class='label'>"._ADMINOPTIONS.":</span> ".(isset($userinfo['validated']) && $userinfo['validated'] ? "[<a href=\"admin.php?action=members&revoke=$uid\" class=\"vuadmin\">"._REVOKEVAL."</a>] " : "[<a href=\"admin.php?action=members&validate=$uid\" class=\"vuadmin\">"._VALIDATE."</a>] ")."[<a href=\"user.php?action=editbio&uid=$uid\" class=\"vuadmin\">"._EDIT."</a>] [<a href=\"admin.php?action=members&delete=$uid\" class=\"vuadmin\">"._DELETE."</a>]";
- $adminopts .= " [<a href=\"admin.php?action=members&".($userinfo['level'] < 0 ? "unlock=".$userinfo['uid']."\" class=\"vuadmin\">"._UNLOCKMEM : "lock=".$userinfo['uid']."\" class=\"vuadmin\">"._LOCKMEM)."</a>]";
+ $adminopts .= " [<a href=\"admin.php?action=members&".(isset($userinfo['level']) < 0 ? "unlock=".($userinfo['uid'] ?? null)."\" class=\"vuadmin\">"._UNLOCKMEM : "lock=".($userinfo['uid'] ?? null)."\" class=\"vuadmin\">"._LOCKMEM)."</a>]";
$adminopts .= " [<a href=\"admin.php?action=admins&".(isset($userinfo['level']) && $userinfo['level'] > 0 ? "revoke=$uid\" class=\"vuadmin\">"._REVOKEADMIN."</a>] [<a href=\"admin.php?action=admins&do=edit&uid=$uid\" class=\"vuadmin\">"._EDITADMIN : "do=new&uid=$uid\" class=\"vuadmin\">"._MAKEADMIN)."</a>]</div>";
$tpl->assign("adminoptions", $adminopts);
}