Revert coauthors array changes as it occasionally brings up an undefined variable warning with no real way to fix it
--- a/includes/corefunctions.php
+++ b/includes/corefunctions.php
@@ -278,20 +278,15 @@
// Same with the author list
function author_link($stories) {
-
- $authlink[] = "<a href=\"" . _BASEDIR . "viewuser.php?uid=" . $stories['uid'] . "\">" . $stories['penname'] . "</a>";
-
- if($stories['coauthors'] && $stories['coauthors_array']) {
+ if(is_array($stories['coauthors'])) {
+ $authlink[] = "<a href=\""._BASEDIR."viewuser.php?uid=".$stories['uid']."\">".$stories['penname']."</a>";
//not needed, why is it there?
- //$coauth = dbquery("SELECT "._PENNAMEFIELD." as penname, co.uid FROM ".TABLEPREFIX."fanfiction_coauthors AS co
- //LEFT JOIN "._AUTHORTABLE." ON co.uid = "._UIDFIELD." WHERE co.sid = '".$stories['sid']."'");
-
- foreach($stories['coauthors_array'] AS $k => $v) {
+ //$coauth = dbquery("SELECT "._PENNAMEFIELD." as penname, co.uid FROM ".TABLEPREFIX."fanfiction_coauthors AS co LEFT JOIN "._AUTHORTABLE." ON co.uid = "._UIDFIELD." WHERE co.sid = '".$stories['sid']."'");
+ foreach($stories['coauthors'] AS $k => $v) {
$authlink[] = "<a href=\""._BASEDIR."viewuser.php?uid=".$k."\">".$v."</a>";
}
}
-
- return implode(", ", $authlink) ;
+ return isset($authlink) ? implode(", ", $authlink) : "<a href=\""._BASEDIR."viewuser.php?uid=".$stories['uid']."\">".$stories['penname']."</a>";
}
// Used to truncate text (summaries in blocks for example) to a set length. An improvement on the old version as this keeps words intact
--- a/includes/storyblock.php
+++ b/includes/storyblock.php
@@ -26,15 +26,15 @@
$tpl->assign("sid", $stories['sid']);
unset($challengelinks, $challengeadmin, $serieslinks, $categorylinks, $adminlinks, $authlink);
if($stories['coauthors'] == 1) {
- $array_coauthors = array();
+ $coauthors = array();
$coauth = dbquery("SELECT "._PENNAMEFIELD." as penname, co.uid FROM ".TABLEPREFIX."fanfiction_coauthors AS co LEFT JOIN "._AUTHORTABLE." ON co.uid = "._UIDFIELD." WHERE co.sid = '".$stories['sid']."'");
while($c = dbassoc($coauth)) {
- $array_coauthors[$c['uid']] = $c['penname'];
+ $coauthors[$c['uid']] = $c['penname'];
}
- $stories['coauthors_array'] = $array_coauthors;
- unset($array_coauthors);
+ $stories['coauthors'] = $coauthors;
+ unset($coauthors);
}
- else $stories['coauthors_array'] = array( );
+ else if(empty($stories['coauthors'])) $stories['coauthors'] = array( );
$tpl->assign("title" , stripslashes(title_link($stories)) );
$tpl->assign("author" , author_link($stories));
$tpl->assign("summary", stripslashes($stories['summary']) );
@@ -108,7 +108,7 @@
}
$tpl->assign("wordcount" , $stories['wordcount'] ? $stories['wordcount'] : "0" );
$tpl->assign("numreviews" , ($reviewsallowed == "1" ? "<a href=\""._BASEDIR."reviews.php?type=ST&item=".$stories['sid']."\">".$stories['reviews']."</a>" : "") );
- if((isADMIN && uLEVEL < 4) || USERUID == $stories['uid'] || (is_array($stories['coauthors']) && array_key_exists(USERUID, $stories['coauthors_array'])))
+ if((isADMIN && uLEVEL < 4) || USERUID == $stories['uid'] || (is_array($stories['coauthors']) && array_key_exists(USERUID, $stories['coauthors'])))
$adminlinks .= "[<a href=\""._BASEDIR."stories.php?action=editstory&sid=".$stories['sid'].(isADMIN ? "&admin=1" : "")."\">"._EDIT."</a>] [<a href=\""._BASEDIR."stories.php?action=delete&sid=".$stories['sid'].(isADMIN ? "&admin=1" : "")."\">"._DELETE."</a>]";
global $featured;
if($stories['featured'] == 1) {
@@ -126,7 +126,7 @@
$tpl->assign("oddeven", ($count % 2 ? "odd" : "even"));
$tpl->assign("reportthis", "[<a href=\""._BASEDIR."contact.php?action=report&url=viewstory.php?sid=".$stories['sid']."\">"._REPORTTHIS."</a>]");
if(isADMIN && uLEVEL < 4) $tpl->assign("adminlinks", "<div class=\"adminoptions\"><span class='label'>"._ADMINOPTIONS.":</span> ".$adminlinks."</div>");
- else if(isMEMBER && (USERUID == $stories['uid'] || array_key_exists(USERUID, $stories['coauthors_array']))) $tpl->assign("adminlinks", "<div class=\"adminoptions\"><span class='label'>"._OPTIONS.":</span> ".$adminlinks."</div>");
+ else if(isMEMBER && (USERUID == $stories['uid'] || array_key_exists(USERUID, $stories['coauthors']))) $tpl->assign("adminlinks", "<div class=\"adminoptions\"><span class='label'>"._OPTIONS.":</span> ".$adminlinks."</div>");
$count++;
?>