Various changes:
author Naram Qashat
()
committer Naram Qashat
()
commit f88fe4a4087490c869ba8303af667e84ef7e0c63
tree 5c1475ff4480db63173207d3005ebf6e986bc295
parent 8c7ff2a0367de1d06646a656056daf795ad2f8b5
Various changes:

* Use enum class instead of enum (except for the enums for the resource IDs, not really necessary there).
* For NCSF specifically, included a function to convert an enum class to its underlying integral type (as this is needed for use with the std::bitset class).
* Cleanup headers so all the ones needed in a file are explicitly included even if they may possibly be included in another header.
* Used forward declarations in a few spots.
* Explicitly namespaced all (u)int*_t uses (this might seem like overkill, but it helps me see when the standard types are being used with a simple search for std::).
* Made sure it all builds with MinGW-w64 as well (both gcc and clang).
* Removed some std::move from DialogBuilder.cpp based on clang's warnings for that.
* Replaced use of std::copy_n on strings in DialogBuilder.cpp with my CopyToString functions that use wcscpy.
* Replaced CHAR_MIN/CHAR_MAX in eqstr.h and ltstr.h with std::numeric_limits<char>::min/max().
55 files changed:
src/in_2sf/XSFConfig_2SF.cpp
src/in_2sf/XSFPlayer_2SF.cpp
src/in_gsf/XSFConfig_GSF.cpp
src/in_gsf/XSFPlayer_GSF.cpp
src/in_ncsf/SSEQPlayer/Channel.cpp
src/in_ncsf/SSEQPlayer/Channel.h
src/in_ncsf/SSEQPlayer/FATSection.cpp
src/in_ncsf/SSEQPlayer/FATSection.h
src/in_ncsf/SSEQPlayer/INFOEntry.cpp
src/in_ncsf/SSEQPlayer/INFOEntry.h
src/in_ncsf/SSEQPlayer/INFOSection.cpp
src/in_ncsf/SSEQPlayer/INFOSection.h
src/in_ncsf/SSEQPlayer/NDSStdHeader.cpp
src/in_ncsf/SSEQPlayer/NDSStdHeader.h
src/in_ncsf/SSEQPlayer/Player.cpp
src/in_ncsf/SSEQPlayer/Player.h
src/in_ncsf/SSEQPlayer/SBNK.cpp
src/in_ncsf/SSEQPlayer/SBNK.h
src/in_ncsf/SSEQPlayer/SDAT.cpp
src/in_ncsf/SSEQPlayer/SDAT.h
src/in_ncsf/SSEQPlayer/SSEQ.cpp
src/in_ncsf/SSEQPlayer/SSEQ.h
src/in_ncsf/SSEQPlayer/SWAR.cpp
src/in_ncsf/SSEQPlayer/SWAR.h
src/in_ncsf/SSEQPlayer/SWAV.cpp
src/in_ncsf/SSEQPlayer/SWAV.h
src/in_ncsf/SSEQPlayer/SYMBSection.cpp
src/in_ncsf/SSEQPlayer/SYMBSection.h
src/in_ncsf/SSEQPlayer/Track.cpp
src/in_ncsf/SSEQPlayer/Track.h
src/in_ncsf/SSEQPlayer/common.h
src/in_ncsf/SSEQPlayer/consts.h
src/in_ncsf/XSFConfig_NCSF.cpp
src/in_ncsf/XSFConfig_NCSF.h
src/in_ncsf/XSFPlayer_NCSF.cpp
src/in_ncsf/XSFPlayer_NCSF.h
src/in_snsf/XSFConfig_SNSF.cpp
src/in_snsf/XSFConfig_SNSF.h
src/in_snsf/XSFPlayer_SNSF.cpp
src/in_xsf_framework/DialogBuilder.cpp
src/in_xsf_framework/DialogBuilder.h
src/in_xsf_framework/TagList.cpp
src/in_xsf_framework/TagList.h
src/in_xsf_framework/XSFCommon.h
src/in_xsf_framework/XSFConfig.cpp
src/in_xsf_framework/XSFConfig.h
src/in_xsf_framework/XSFConfig_Winamp.cpp
src/in_xsf_framework/XSFFile.cpp
src/in_xsf_framework/XSFFile.h
src/in_xsf_framework/XSFPlayer.cpp
src/in_xsf_framework/XSFPlayer.h
src/in_xsf_framework/convert.h
src/in_xsf_framework/eqstr.h
src/in_xsf_framework/in_xsf.cpp
src/in_xsf_framework/ltstr.h