Browse code

Old XSS fix from 2012/03/14; somehow evaded getting updated!

Clarissa Walker authored on 2015/09/09 23:38:09
Showing 1 changed files
... ...
@@ -78,12 +78,17 @@ elseif (isset($_POST["create_css"]))
78 78
 	{
79 79
 		if (!file_exists("./css/" . filterData($_POST["create_css"])))
80 80
 		{
81
-			if (copy("./css/style.css", "./css/" . filterData($_POST["create_css"])))
82
-				echo "<p class=\"success\">" . filterData($_POST["create_css"]) . ", was created successfuly</p>";
81
+			if (filterData($_POST["create_css"]) == ".css")
82
+			{
83
+				echo errorMessage() . "Error: Should not create .css file with only an extension!</p>";
84
+				exit();
85
+			}
86
+			elseif (copy("./css/style.css", "./css/" . filterData($_POST["create_css"])))
87
+				echo "<p class=\"success\">" . filterData($_POST["create_css"]) . " was created successfully</p>";
83 88
 			else
84 89
 			{
85 90
 				echo errorMessage() . "Error: Unable to create " . filterData($_POST["create_css"]) . ", are you sure the permissions are correct?</p>";
86
-				exit();			
91
+				exit();
87 92
 			}
88 93
 		}
89 94
 		else
... ...
@@ -146,7 +151,7 @@ if (isset($_POST["create_css"]) || isset($_POST["edit_css"]))
146 151
 	<h2>Editing File: <?php echo $filename;?></h2>
147 152
 	<form action="<?php echo htmlentities($_SERVER['PHP_SELF']);?>" method="post">
148 153
 	<input type="hidden" name="hidden_filename" value="<?php echo $filename;?>"/>
149
-	<input type="hidden" name="current_css_file" value="<?php echo $_POST['current_css_file'];?>"/>
154
+	<input type="hidden" name="current_css_file" value="<?php echo filterData($_POST['current_css_file']);?>"/>
150 155
 	<textarea name="file_contents" cols="120" rows="20"><?php
151 156
 	//open css file
152 157
 	readfile("./css/" . $filename);