Browse code

Various changes:

* Use enum class instead of enum (except for the enums for the resource IDs, not really necessary there).
* For NCSF specifically, included a function to convert an enum class to its underlying integral type (as this is needed for use with the std::bitset class).
* Cleanup headers so all the ones needed in a file are explicitly included even if they may possibly be included in another header.
* Used forward declarations in a few spots.
* Explicitly namespaced all (u)int*_t uses (this might seem like overkill, but it helps me see when the standard types are being used with a simple search for std::).
* Made sure it all builds with MinGW-w64 as well (both gcc and clang).
* Removed some std::move from DialogBuilder.cpp based on clang's warnings for that.
* Replaced use of std::copy_n on strings in DialogBuilder.cpp with my CopyToString functions that use wcscpy.
* Replaced CHAR_MIN/CHAR_MAX in eqstr.h and ltstr.h with std::numeric_limits<char>::min/max().

Naram Qashat authored on 2021/03/21 03:16:45
Showing 1 changed files
... ...
@@ -8,15 +8,18 @@
8 8
 
9 9
 #pragma once
10 10
 
11
-#include "common.h"
11
+#include <string>
12
+#include <cstdint>
13
+
14
+struct PseudoFile;
12 15
 
13 16
 struct NDSStdHeader
14 17
 {
15
-	int8_t type[4];
16
-	uint32_t magic;
18
+	std::int8_t type[4];
19
+	std::uint32_t magic;
17 20
 
18 21
 	NDSStdHeader();
19 22
 
20 23
 	void Read(PseudoFile &file);
21
-	void Verify(const std::string &typeToCheck, uint32_t magicToCheck);
24
+	void Verify(const std::string &typeToCheck, std::uint32_t magicToCheck);
22 25
 };
Browse code

Remove last modification date from files.

(I never remember to update these and besides, GitHub history can show when they were last modified.)

Naram Qashat authored on 2021/03/19 10:58:12
Showing 1 changed files
... ...
@@ -1,7 +1,6 @@
1 1
 /*
2 2
  * SSEQ Player - Nintendo DS Standard Header structure
3 3
  * By Naram Qashat (CyberBotX) [cyberbotx@cyberbotx.com]
4
- * Last modification on 2014-09-08
5 4
  *
6 5
  * Nintendo DS Nitro Composer (SDAT) Specification document found at
7 6
  * http://www.feshrine.net/hacking/doc/nds-sdat.html
Browse code

Use #pragma once instead of include guards.

Naram Qashat authored on 2014/09/08 14:47:36
Showing 1 changed files
... ...
@@ -1,14 +1,13 @@
1 1
 /*
2 2
  * SSEQ Player - Nintendo DS Standard Header structure
3 3
  * By Naram Qashat (CyberBotX) [cyberbotx@cyberbotx.com]
4
- * Last modification on 2013-03-21
4
+ * Last modification on 2014-09-08
5 5
  *
6 6
  * Nintendo DS Nitro Composer (SDAT) Specification document found at
7 7
  * http://www.feshrine.net/hacking/doc/nds-sdat.html
8 8
  */
9 9
 
10
-#ifndef SSEQPLAYER_NDSSTDHEADER_H
11
-#define SSEQPLAYER_NDSSTDHEADER_H
10
+#pragma once
12 11
 
13 12
 #include "common.h"
14 13
 
... ...
@@ -22,5 +21,3 @@ struct NDSStdHeader
22 21
 	void Read(PseudoFile &file);
23 22
 	void Verify(const std::string &typeToCheck, uint32_t magicToCheck);
24 23
 };
25
-
26
-#endif
Browse code

Import actual code.

Naram Qashat authored on 2013/03/26 02:41:19
Showing 1 changed files
1 1
new file mode 100644
... ...
@@ -0,0 +1,26 @@
1
+/*
2
+ * SSEQ Player - Nintendo DS Standard Header structure
3
+ * By Naram Qashat (CyberBotX) [cyberbotx@cyberbotx.com]
4
+ * Last modification on 2013-03-21
5
+ *
6
+ * Nintendo DS Nitro Composer (SDAT) Specification document found at
7
+ * http://www.feshrine.net/hacking/doc/nds-sdat.html
8
+ */
9
+
10
+#ifndef SSEQPLAYER_NDSSTDHEADER_H
11
+#define SSEQPLAYER_NDSSTDHEADER_H
12
+
13
+#include "common.h"
14
+
15
+struct NDSStdHeader
16
+{
17
+	int8_t type[4];
18
+	uint32_t magic;
19
+
20
+	NDSStdHeader();
21
+
22
+	void Read(PseudoFile &file);
23
+	void Verify(const std::string &typeToCheck, uint32_t magicToCheck);
24
+};
25
+
26
+#endif