CW Cyrix's Git Repository Mirror
Browse code

Various changes:

* Use enum class instead of enum (except for the enums for the resource IDs, not really necessary there).
* For NCSF specifically, included a function to convert an enum class to its underlying integral type (as this is needed for use with the std::bitset class).
* Cleanup headers so all the ones needed in a file are explicitly included even if they may possibly be included in another header.
* Used forward declarations in a few spots.
* Explicitly namespaced all (u)int*_t uses (this might seem like overkill, but it helps me see when the standard types are being used with a simple search for std::).
* Made sure it all builds with MinGW-w64 as well (both gcc and clang).
* Removed some std::move from DialogBuilder.cpp based on clang's warnings for that.
* Replaced use of std::copy_n on strings in DialogBuilder.cpp with my CopyToString functions that use wcscpy.
* Replaced CHAR_MIN/CHAR_MAX in eqstr.h and ltstr.h with std::numeric_limits<char>::min/max().

Naram Qashat authored on 2021/03/21 03:16:45
Showing 1 changed files
src/in_ncsf/SSEQPlayer/SWAR.h
History View file @ f88fe4a
... ... 
@@ -9,14 +9,17 @@
9 9 
 #pragma once
10 10
11 11 
 #include <map>
12 
-#include "SWAV.h"
12 
+#include <string>
13 
+#include <cstdint>
13 14 
 #include "INFOEntry.h"
14 
-#include "common.h"
15 
+#include "SWAV.h"
16 
+
17 
+struct PseudoFile;
15 18
16 19 
 struct SWAR
17 20 
 {
18 21 
 	std::string filename;
19 
-	std::map<uint32_t, SWAV> swavs;
22 
+	std::map<std::uint32_t, SWAV> swavs;
20 23
21 24 
 	INFOEntryWAVEARC info;
22 25
Browse code

Cleanup a few comments and strings.

Naram Qashat authored on 2021/03/20 20:25:12
Showing 1 changed files
src/in_ncsf/SSEQPlayer/SWAR.h
History View file @ 27b156f
... ... 
@@ -13,9 +13,6 @@
13 13 
 #include "INFOEntry.h"
14 14 
 #include "common.h"
15 15
16 
-/*
17 
- * The size has been left out of this structure as it is unused by this player.
18 
- */
19 16 
 struct SWAR
20 17 
 {
21 18 
 	std::string filename;
Browse code

Remove last modification date from files.

(I never remember to update these and besides, GitHub history can show when they were last modified.)

Naram Qashat authored on 2021/03/19 10:58:12
Showing 1 changed files
src/in_ncsf/SSEQPlayer/SWAR.h
History View file @ e50612d
... ... 
@@ -1,7 +1,6 @@
1 1 
 /*
2 2 
  * SSEQ Player - SDAT SWAR (Wave Archive) structures
3 3 
  * By Naram Qashat (CyberBotX) [cyberbotx@cyberbotx.com]
4 
- * Last modification on 2014-09-08
5 4 
  *
6 5 
  * Nintendo DS Nitro Composer (SDAT) Specification document found at
7 6 
  * http://www.feshrine.net/hacking/doc/nds-sdat.html
Browse code

Use #pragma once instead of include guards.

Naram Qashat authored on 2014/09/08 14:47:36
Showing 1 changed files
src/in_ncsf/SSEQPlayer/SWAR.h
History View file @ b6add6e
... ... 
@@ -1,14 +1,13 @@
1 1 
 /*
2 2 
  * SSEQ Player - SDAT SWAR (Wave Archive) structures
3 3 
  * By Naram Qashat (CyberBotX) [cyberbotx@cyberbotx.com]
4 
- * Last modification on 2013-03-21
4 
+ * Last modification on 2014-09-08
5 5 
  *
6 6 
  * Nintendo DS Nitro Composer (SDAT) Specification document found at
7 7 
  * http://www.feshrine.net/hacking/doc/nds-sdat.html
8 8 
  */
9 9
10 
-#ifndef SSEQPLAYER_SWAR_H
11 
-#define SSEQPLAYER_SWAR_H
10 
+#pragma once
12 11
13 12 
 #include <map>
14 13 
 #include "SWAV.h"
... ... 
@@ -29,5 +28,3 @@ struct SWAR
29 28
30 29 
 	void Read(PseudoFile &file);
31 30 
 };
32 
-
33 
-#endif
Browse code

Import actual code.

Naram Qashat authored on 2013/03/26 02:41:19
Showing 1 changed files
src/in_ncsf/SSEQPlayer/SWAR.h
History View file @ bc076aa
1 1 
new file mode 100644
... ... 
@@ -0,0 +1,33 @@
1 
+/*
2 
+ * SSEQ Player - SDAT SWAR (Wave Archive) structures
3 
+ * By Naram Qashat (CyberBotX) [cyberbotx@cyberbotx.com]
4 
+ * Last modification on 2013-03-21
5 
+ *
6 
+ * Nintendo DS Nitro Composer (SDAT) Specification document found at
7 
+ * http://www.feshrine.net/hacking/doc/nds-sdat.html
8 
+ */
9 
+
10 
+#ifndef SSEQPLAYER_SWAR_H
11 
+#define SSEQPLAYER_SWAR_H
12 
+
13 
+#include <map>
14 
+#include "SWAV.h"
15 
+#include "INFOEntry.h"
16 
+#include "common.h"
17 
+
18 
+/*
19 
+ * The size has been left out of this structure as it is unused by this player.
20 
+ */
21 
+struct SWAR
22 
+{
23 
+	std::string filename;
24 
+	std::map<uint32_t, SWAV> swavs;
25 
+
26 
+	INFOEntryWAVEARC info;
27 
+
28 
+	SWAR(const std::string &fn = "");
29 
+
30 
+	void Read(PseudoFile &file);
31 
+};
32 
+
33 
+#endif