Notable differences from upstream:
* Did not use the same #include setup for the new byuu apu and instead chose to do things more traditionally, as the latter is also much easier to deal with in Visual Studio than just including .cpp files into other .cpp files...
* MSU1 support not included (I see no need for this in a plugin meant to be used for original SNES music).
* The dynamic rate control on the APU not included (I also see no need for it in this plugin).
* The extra resamplers I added in were removed as the original hermite resampler was folded into a single non-inhertiable resampler.
* Bits of cleanup.
| ... | ... |
@@ -31,7 +31,7 @@ class XSFConfigDialog_SNSF : public XSFConfigDialog |
| 31 | 31 |
public: |
| 32 | 32 |
XSFConfigDialog_SNSF(XSFConfig &newConfig, wxWindow *parent, const wxString &title); |
| 33 | 33 |
|
| 34 |
- bool reverseStereo; |
|
| 35 |
- int resampler; |
|
| 34 |
+ bool separateEchoBuffer; |
|
| 35 |
+ int interpolation; |
|
| 36 | 36 |
wxArrayInt mute; |
| 37 | 37 |
}; |
* These were mostly copied from the old Makefile.
* The files including wxWidgets need -Wno-old-style-cast done in the code via pragmas because I do not want to disable that warning for the rest of the files. (It might've been overkill for some places where wxWidgets was included, but whatever.)
| ... | ... |
@@ -7,7 +7,19 @@ |
| 7 | 7 |
|
| 8 | 8 |
#pragma once |
| 9 | 9 |
|
| 10 |
+#ifdef __GNUC__ |
|
| 11 |
+# pragma GCC diagnostic push |
|
| 12 |
+# pragma GCC diagnostic ignored "-Wold-style-cast" |
|
| 13 |
+#elif defined(__clang__) |
|
| 14 |
+# pragma clang diagnostic push |
|
| 15 |
+# pragma clang diagnostic ignored "-Wold-style-cast" |
|
| 16 |
+#endif |
|
| 10 | 17 |
#include <wx/dynarray.h> |
| 18 |
+#ifdef __GNUC__ |
|
| 19 |
+# pragma GCC diagnostic pop |
|
| 20 |
+#elif defined(__clang__) |
|
| 21 |
+# pragma clang diagnostic pop |
|
| 22 |
+#endif |
|
| 11 | 23 |
#include "XSFConfigDialog.h" |
| 12 | 24 |
|
| 13 | 25 |
class wxString; |
| ... | ... |
@@ -17,7 +29,7 @@ class XSFConfig; |
| 17 | 29 |
class XSFConfigDialog_SNSF : public XSFConfigDialog |
| 18 | 30 |
{
|
| 19 | 31 |
public: |
| 20 |
- XSFConfigDialog_SNSF(XSFConfig &config, wxWindow *parent, const wxString &title); |
|
| 32 |
+ XSFConfigDialog_SNSF(XSFConfig &newConfig, wxWindow *parent, const wxString &title); |
|
| 21 | 33 |
|
| 22 | 34 |
bool reverseStereo; |
| 23 | 35 |
int resampler; |
* Removes the configuration dialog boxes that used my DialogBuilder.
* Move default configuration values to be inlined within the headers.
* Moved 2SF's and GSF's XSFConfig classes to their own headers to accommodate the new wxWidgets dialog boxes.
* Make it so NCSF's SoundView dialog can be toggled on or off from the configuration dialog box.
| 1 | 1 |
new file mode 100644 |
| ... | ... |
@@ -0,0 +1,25 @@ |
| 1 |
+/* |
|
| 2 |
+ * xSF - SNSF configuration dialog |
|
| 3 |
+ * By Naram Qashat (CyberBotX) [cyberbotx@cyberbotx.com] |
|
| 4 |
+ * |
|
| 5 |
+ * Partially based on the vio*sf framework |
|
| 6 |
+ */ |
|
| 7 |
+ |
|
| 8 |
+#pragma once |
|
| 9 |
+ |
|
| 10 |
+#include <wx/dynarray.h> |
|
| 11 |
+#include "XSFConfigDialog.h" |
|
| 12 |
+ |
|
| 13 |
+class wxString; |
|
| 14 |
+class wxWindow; |
|
| 15 |
+class XSFConfig; |
|
| 16 |
+ |
|
| 17 |
+class XSFConfigDialog_SNSF : public XSFConfigDialog |
|
| 18 |
+{
|
|
| 19 |
+public: |
|
| 20 |
+ XSFConfigDialog_SNSF(XSFConfig &config, wxWindow *parent, const wxString &title); |
|
| 21 |
+ |
|
| 22 |
+ bool reverseStereo; |
|
| 23 |
+ int resampler; |
|
| 24 |
+ wxArrayInt mute; |
|
| 25 |
+}; |