Browse code

docs/config.php, install/install.php: do not interpolate strings in any config.php file - security

Clarissa Walker authored on 2026/10/25 19:02:57
Showing 2 changed files
... ...
@@ -1,10 +1,10 @@
1 1
 <?php 
2
-$dbhost = "localhost";
3
-$dbname = "dbname";
4
-$dbuser= "dbuser";
5
-$dbpass = "dbpass";
6
-$sitekey = "";
7
-$settingsprefix = "settings";
2
+$dbhost = 'localhost';
3
+$dbname = 'dbname';
4
+$dbuser= 'dbuser';
5
+$dbpass = 'dbpass';
6
+$sitekey = '';
7
+$settingsprefix = 'settings';
8 8
 
9 9
 include("includes/dbfunctions.php");
10 10
 ?>
... ...
@@ -1027,12 +1027,12 @@ CREATE TABLE IF NOT EXISTS `" . $tableprefix . "fanfiction_modules` (
1027 1027
 				$language = $_POST['language'];
1028 1028
 				$settingsprefix = descript($_POST['settingsprefix']);
1029 1029
 				$text = "<?php \n".
1030
-					"\$dbhost = \"$dbhost\";\n".
1031
-					"\$dbname = \"$dbname\";\n".
1032
-					"\$dbuser= \"$dbuser\";\n".
1033
-					"\$dbpass = \"$dbpass\";\n".
1034
-					"\$sitekey = \"$sitekey\";\n".
1035
-					"\$settingsprefix = \"$settingsprefix\";\n\n".
1030
+					"\$dbhost = ".var_export(($dbhost), true).";\n".
1031
+					"\$dbname = ".var_export(($dbname), true).";\n".
1032
+					"\$dbuser= ".var_export(($dbuser), true).";\n".
1033
+					"\$dbpass = ".var_export(($dbpass), true).";\n".
1034
+					"\$sitekey = ".var_export(($sitekey), true).";\n".
1035
+					"\$settingsprefix = ".var_export(($settingsprefix), true).";\n\n".
1036 1036
 					"include(\"includes/dbfunctions.php\");\n".
1037 1037
 					"?>";
1038 1038