Browse code

fix session.upload_progress.enabled check - always used else statement otherwise

Clarissa Walker authored on 2026/11/21 12:50:04
Showing 3 changed files
... ...
@@ -53,7 +53,8 @@ unset($v);
53 53
 // as of CVE-2026-115560, you can no longer set these settings if
54 54
 // session.upload_progress.enabled is set to 'On'
55 55
 if(!isset($_SESSION)) {
56
-	if (ini_get('session.upload_progress.enabled' == 0) && (version_compare(PHP_VERSION, '7.3.0', '>='))) {
56
+	$sessionuploadprogress = ini_get('session.upload_progress.enabled');
57
+	if (($sessionuploadprogress != 1) && (version_compare(PHP_VERSION, '7.3.0', '>='))) {
57 58
 		ini_set('session.cookie_httponly', '1');
58 59
 		ini_set('session.cookie_samesite', 'Lax');
59 60
 		session_start();
... ...
@@ -30,7 +30,8 @@ else $current = "login";
30 30
 	if(!empty($_POST['submit']) && $current == "login") {
31 31
 	// as of CVE-2026-115560, you can no longer set these settings if
32 32
 	// session.upload_progress.enabled is set to 'On'
33
-	if (ini_get('session.upload_progress.enabled' == 0) && (version_compare(PHP_VERSION, '7.3.0', '>='))) {
33
+	$sessionuploadprogress = ini_get('session.upload_progress.enabled');
34
+	if (($sessionuploadprogress != 1) && (version_compare(PHP_VERSION, '7.3.0', '>='))) {
34 35
 		ini_set('session.cookie_httponly', '1');
35 36
 		ini_set('session.cookie_samesite', 'Lax');
36 37
 		session_start();
... ...
@@ -72,7 +72,8 @@
72 72
 			// as of CVE-2026-115560, you can no longer set these settings if
73 73
 			// session.upload_progress.enabled is set to 'On'
74 74
 			if(!isset($_SESSION)) {
75
-				if (ini_get('session.upload_progress.enabled' == 0) && (version_compare(PHP_VERSION, '7.3.0', '>='))) {
75
+				$sessionuploadprogress = ini_get('session.upload_progress.enabled');
76
+				if (($sessionuploadprogress != 1) && (version_compare(PHP_VERSION, '7.3.0', '>='))) {
76 77
 					ini_set('session.cookie_httponly', '1');
77 78
 					ini_set('session.cookie_samesite', 'Lax');
78 79
 					session_start();